Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2427043003: Enable the IAT patcher unittests in x64. (Closed)

Created:
4 years, 2 months ago by Sébastien Marchand
Modified:
4 years, 2 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Patch Set 1 : fixes #

Patch Set 2 : Make IAT patcher work in x64. #

Patch Set 3 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M syzygy/agent/asan/asan.gyp View 2 chunks +7 lines, -4 lines 0 comments Download
M syzygy/agent/asan/iat_patcher_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + syzygy/pe/export_dll_x64.def View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M syzygy/pe/pe.gyp View 1 2 chunks +25 lines, -0 lines 0 comments Download
M syzygy/pe/test_dll_x64.def View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Sébastien Marchand
PTAL.
4 years, 2 months ago (2016-10-19 14:45:06 UTC) #5
Sébastien Marchand
+siggi@ , I was wrong, base::win::PEImage works with x64 binaries.
4 years, 2 months ago (2016-10-19 15:12:04 UTC) #7
chrisha
This isn't so much "making it work" as it is, "enabling the unittest"? lgtm
4 years, 2 months ago (2016-10-19 15:22:34 UTC) #8
Sébastien Marchand
Yeah, the problem was that it required to get test_dll to compile in x64 but ...
4 years, 2 months ago (2016-10-19 15:24:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427043003/100001
4 years, 2 months ago (2016-10-19 15:24:37 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 16:16:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://github.com/google/syzygy/commit/5466bca986569a2169e7354df425c09e29faeed6

Powered by Google App Engine
This is Rietveld 408576698