Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ios/chrome/browser/snapshots/snapshot_cache_unittest.mm

Issue 2426823002: Removed use of IsRunningOnIOS8OrLater from snapshots code. (Closed)
Patch Set: addressed comments from sdefresne Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/snapshots/snapshots_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
diff --git a/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm b/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
index ef3145d505995afe4aa74d6ca81610742849d458..4243130e7a701767a95048ca2a4e3e5f23197054 100644
--- a/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
+++ b/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
@@ -349,10 +349,11 @@ TEST_F(SnapshotCacheTest, Purge) {
// Loads the color images into the cache, and pins two of them. Ensures that
// only the two pinned IDs remain in memory after a call to -handleLowMemory.
TEST_F(SnapshotCacheTest, HandleLowMemory) {
-// TODO(droger): This test fails on iPad iOS8 device: http://crbug.com/455209
+// TODO(crbug.com/455209): This test failed on iPad iOS8 device, but may no
+// longer be failing on iOS 9 and up. Should test by re-enabling and monitor.
#if !TARGET_IPHONE_SIMULATOR
- if (IsIPadIdiom() && base::ios::IsRunningOnIOS8OrLater()) {
- LOG(WARNING) << "Test disabled on iPad iOS8 device.";
+ if (IsIPadIdiom()) {
+ LOG(WARNING) << "Test disabled on iPad device.";
return;
}
#endif
« no previous file with comments | « no previous file | ios/chrome/browser/snapshots/snapshots_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698