Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: ios/chrome/browser/snapshots/snapshot_cache_unittest.mm

Issue 2426823002: Removed use of IsRunningOnIOS8OrLater from snapshots code. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
diff --git a/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm b/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
index ef3145d505995afe4aa74d6ca81610742849d458..dc0e5f1577ed005d974603e5b8d32526f9bfdb49 100644
--- a/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
+++ b/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
@@ -351,8 +351,8 @@ TEST_F(SnapshotCacheTest, Purge) {
TEST_F(SnapshotCacheTest, HandleLowMemory) {
// TODO(droger): This test fails on iPad iOS8 device: http://crbug.com/455209
sdefresne 2016/10/19 18:22:27 I've unassigned the bug so that we investigate whe
pkl (ping after 24h if needed) 2016/10/19 20:35:03 Updated this comment and crbug.
#if !TARGET_IPHONE_SIMULATOR
- if (IsIPadIdiom() && base::ios::IsRunningOnIOS8OrLater()) {
- LOG(WARNING) << "Test disabled on iPad iOS8 device.";
+ if (IsIPadIdiom()) {
+ LOG(WARNING) << "Test disabled on iPad device.";
return;
}
#endif
« no previous file with comments | « no previous file | ios/chrome/browser/snapshots/snapshots_util.mm » ('j') | ios/chrome/browser/snapshots/snapshots_util.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698