Removed use of IsRunningOnIOS8OrLater from snapshots code.

Removed use of IsRunningOnIOS8OrLater from snapshots code.

BUG=633626
Committed: https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355
Cr-Commit-Position: refs/heads/master@{#426287}

[pkl (ping after 24h if needed), 2016-10-18 00:18:03]

pkl@chromium.org changed reviewers:
+ jif@chromium.org, rohitrao@chromium.org

[pkl (ping after 24h if needed), 2016-10-18 00:18:03]

Clean up pre-iOS8

[jif, 2016-10-18 00:23:36]

lgtm

[pkl (ping after 24h if needed), 2016-10-19 16:36:57]

The CQ bit was checked by pkl@chromium.org

[commit-bot: I haz the power, 2016-10-19 16:37:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 17:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:07:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkl (ping after 24h if needed), 2016-10-19 17:51:46]

pkl@chromium.org changed reviewers:
+ sdefresne@chromium.org

[pkl (ping after 24h if needed), 2016-10-19 17:51:46]

rohitrao | sdefresne: OWNERS/committer l-g-t-m please.

[sdefresne, 2016-10-19 18:22:27]

lgtm with one nit

https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/s...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/s...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:352: // TODO(droger):
This test fails on iPad iOS8 device: http://crbug.com/455209
I've unassigned the bug so that we investigate whether this is still failing or
not.

https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/s...
File ios/chrome/browser/snapshots/snapshots_util.mm (right):

https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/s...
ios/chrome/browser/snapshots/snapshots_util.mm:45:
snapshotsDir.Append("Snapshots").Append(base::mac::BaseBundleID());
nit: (or however "git cl format" format this)

snapshotsDir = snapshotsDir
    .Append("Snapshots")
    .Append(base::mac::BaseBundleID())
    .Append(base::mac::BaseBundleID());

[pkl (ping after 24h if needed), 2016-10-19 20:35:03]

Thank you ! Submitting.

https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:352: // TODO(droger):
This test fails on iPad iOS8 device: http://crbug.com/455209
On 2016/10/19 18:22:27, sdefresne wrote:
> I've unassigned the bug so that we investigate whether this is still failing
or
> not.

Updated this comment and crbug.

https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshots_util.mm (right):

https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshots_util.mm:45:
snapshotsDir.Append("Snapshots").Append(base::mac::BaseBundleID());
On 2016/10/19 18:22:27, sdefresne wrote:
> nit: (or however "git cl format" format this)
> 
> snapshotsDir = snapshotsDir
>     .Append("Snapshots")
>     .Append(base::mac::BaseBundleID())
>     .Append(base::mac::BaseBundleID());

git cl format'ed

[pkl (ping after 24h if needed), 2016-10-19 20:35:12]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2016-10-19 20:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2426823002/#ps20001
(title: "addressed comments from sdefresne")

[commit-bot: I haz the power, 2016-10-19 20:36:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 21:25:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:11:32]

Description was changed from

==========
Removed use of IsRunningOnIOS8OrLater from snapshots code.

BUG=633626
==========

to

==========
Removed use of IsRunningOnIOS8OrLater from snapshots code.

BUG=633626

Committed: https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355
Cr-Commit-Position: refs/heads/master@{#426287}
==========

[commit-bot: I haz the power, 2016-10-21 13:11:33]

Patchset 2 (id:??) landed as
https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355
Cr-Commit-Position: refs/heads/master@{#426287}