Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2426823002: Removed use of IsRunningOnIOS8OrLater from snapshots code. (Closed)

Created:
4 years, 2 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed use of IsRunningOnIOS8OrLater from snapshots code. BUG=633626 Committed: https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355 Cr-Commit-Position: refs/heads/master@{#426287}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments from sdefresne #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 1 1 chunk +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshots_util.mm View 1 1 chunk +4 lines, -10 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshots_util_unittest.mm View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
pkl (ping after 24h if needed)
Clean up pre-iOS8
4 years, 2 months ago (2016-10-18 00:18:03 UTC) #2
jif
lgtm
4 years, 2 months ago (2016-10-18 00:23:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426823002/1
4 years, 2 months ago (2016-10-19 16:37:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/285169)
4 years, 2 months ago (2016-10-19 17:07:24 UTC) #7
pkl (ping after 24h if needed)
rohitrao | sdefresne: OWNERS/committer l-g-t-m please.
4 years, 2 months ago (2016-10-19 17:51:46 UTC) #9
sdefresne
lgtm with one nit https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right): https://chromiumcodereview.appspot.com/2426823002/diff/1/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm#newcode352 ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:352: // TODO(droger): This test fails ...
4 years, 2 months ago (2016-10-19 18:22:27 UTC) #10
pkl (ping after 24h if needed)
Thank you ! Submitting. https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right): https://codereview.chromium.org/2426823002/diff/1/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm#newcode352 ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:352: // TODO(droger): This test fails ...
4 years, 2 months ago (2016-10-19 20:35:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426823002/20001
4 years, 2 months ago (2016-10-19 20:36:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 21:25:13 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:33 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355
Cr-Commit-Position: refs/heads/master@{#426287}

Powered by Google App Engine
This is Rietveld 408576698