Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8246)

Unified Diff: content/renderer/pepper/content_decryptor_delegate.cc

Issue 2426813002: EME: Close existing sessions on CDM failure (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/content_decryptor_delegate.cc
diff --git a/content/renderer/pepper/content_decryptor_delegate.cc b/content/renderer/pepper/content_decryptor_delegate.cc
index fc588545138ecab2c5432438db4b2819ae51633a..7aace26e744bdba79ea4ddbe2a60df06cd86d66f 100644
--- a/content/renderer/pepper/content_decryptor_delegate.cc
+++ b/content/renderer/pepper/content_decryptor_delegate.cc
@@ -743,6 +743,7 @@ void ContentDecryptorDelegate::OnPromiseResolvedWithSession(uint32_t promise_id,
PP_Var session_id) {
StringVar* session_id_string = StringVar::FromPPVar(session_id);
DCHECK(session_id_string);
+ cdm_session_tracker_.AddSession(session_id_string->value());
cdm_promise_adapter_.ResolvePromise(promise_id, session_id_string->value());
}
@@ -822,13 +823,12 @@ void ContentDecryptorDelegate::OnSessionExpirationChange(
}
void ContentDecryptorDelegate::OnSessionClosed(PP_Var session_id) {
- if (session_closed_cb_.is_null())
- return;
-
StringVar* session_id_string = StringVar::FromPPVar(session_id);
DCHECK(session_id_string);
- session_closed_cb_.Run(session_id_string->value());
+ cdm_session_tracker_.RemoveSession(session_id_string->value());
+ if (!session_closed_cb_.is_null())
+ session_closed_cb_.Run(session_id_string->value());
}
void ContentDecryptorDelegate::DecoderInitializeDone(
@@ -1258,6 +1258,8 @@ void ContentDecryptorDelegate::SatisfyAllPendingCallbacksOnError() {
video_decode_cb_.ResetAndReturn().Run(media::Decryptor::kError, NULL);
cdm_promise_adapter_.Clear();
+
+ cdm_session_tracker_.CloseRemainingSessions(session_closed_cb_);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698