media: Reorganize media unittests

media: Reorganize media unittests

- Put the current "media" unittest files in a source_set.
- Add a "media_base_unittests" target which includes only "media"
  unittests.
- Update "media_unittests" so that it includes "media" unittests for now
  but in the future it will also include tests for other subfolders,
  e.g. caputre, remoting, mojo etc.
- Also rename "unittests" targets to "unit_tests" to be consistent to
  the rest of the codebase.

BUG=656112
TEST=This only reorganizes tests and doesn't change any existing tests.

Committed: https://crrev.com/f072c4c56b530b857771e3eea4358ba0daea3c19
Cr-Commit-Position: refs/heads/master@{#426665}

[xhwang, 2016-10-18 22:54:56]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 22:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-18 23:15:39]

xhwang@chromium.org changed reviewers:
+ watk@chromium.org

[xhwang, 2016-10-18 23:15:40]

PTAL

[xhwang, 2016-10-18 23:16:18]

mcasas/miu/xjz: FYI

[commit-bot: I haz the power, 2016-10-18 23:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:29:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[miu, 2016-10-18 23:40:50]

So, when we add media/remoting, will it be okay to add the mojo EDK init call in
main() in media/test/run_all_unittests.cc?

[watk, 2016-10-18 23:42:22]

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:721: test("media_base_unittests") {
I only have nits/discussion points:

* I don't love the name because it's surprising that this isn't only  for
targets in //media/base. Is media_core_unittests less ambiguous?

* minor, but might be worth leaving out this new target until your next CL that
makes it different. Weird to have identical targets for the interim.

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:728: # Contains tests for all targets in "media" folder.
s/in "media"/in the "media"/

[watk, 2016-10-18 23:46:19]

lgtm

[xhwang, 2016-10-19 06:03:07]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 06:05:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 09:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 09:54:00]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[xhwang, 2016-10-20 07:15:03]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 07:15:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-20 07:32:47]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-20 08:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:48:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[xhwang, 2016-10-20 16:33:09]

Comments addressed. Sorry for the delay.

Now it seems android bots are broken, I'll fix it today.

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:721: test("media_base_unittests") {
On 2016/10/18 23:42:22, watk wrote:
> I only have nits/discussion points:
> 
> * I don't love the name because it's surprising that this isn't only  for
> targets in //media/base. Is media_core_unittests less ambiguous?

Agreed. But I don't like media_core_unittests since it's hard to figure out what
is "core".

Updated so that media_base_unittests only covers media/base:unit_tests.

> * minor, but might be worth leaving out this new target until your next CL
that
> makes it different. Weird to have identical targets for the interim.

Now this isn't a problem anymore.

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:728: # Contains tests for all targets in "media" folder.
On 2016/10/18 23:42:22, watk wrote:
> s/in "media"/in the "media"/

Done.

[watk, 2016-10-20 21:24:20]

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://chromiumcodereview.appspot.com/2426773005/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:721: test("media_base_unittests") {
On 2016/10/20 16:33:09, xhwang wrote:
> On 2016/10/18 23:42:22, watk wrote:
> > I only have nits/discussion points:
> > 
> > * I don't love the name because it's surprising that this isn't only  for
> > targets in //media/base. Is media_core_unittests less ambiguous?
> 
> Agreed. But I don't like media_core_unittests since it's hard to figure out
what
> is "core".

Sounds good. I prefer not having a target for an unclear subset of tests as
well.

[xhwang, 2016-10-20 22:58:19]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-21 00:04:17]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-10-21 00:04:17]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-10-21 00:04:18]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org
Link to the patchset: https://codereview.chromium.org/2426773005/#ps60001
(title: "fix android")

[commit-bot: I haz the power, 2016-10-21 00:04:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 00:54:00]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:25:13]

Description was changed from

==========
media: Reorganize media unittests

- Put the current "media" unittest files in a source_set.
- Add a "media_base_unittests" target which includes only "media"
  unittests.
- Update "media_unittests" so that it includes "media" unittests for now
  but in the future it will also include tests for other subfolders,
  e.g. caputre, remoting, mojo etc.
- Also rename "unittests" targets to "unit_tests" to be consistent to
  the rest of the codebase.

BUG=656112
TEST=This only reorganizes tests and doesn't change any existing tests.
==========

to

==========
media: Reorganize media unittests

- Put the current "media" unittest files in a source_set.
- Add a "media_base_unittests" target which includes only "media"
  unittests.
- Update "media_unittests" so that it includes "media" unittests for now
  but in the future it will also include tests for other subfolders,
  e.g. caputre, remoting, mojo etc.
- Also rename "unittests" targets to "unit_tests" to be consistent to
  the rest of the codebase.

BUG=656112
TEST=This only reorganizes tests and doesn't change any existing tests.

Committed: https://crrev.com/f072c4c56b530b857771e3eea4358ba0daea3c19
Cr-Commit-Position: refs/heads/master@{#426665}
==========

[commit-bot: I haz the power, 2016-10-21 13:25:14]

Patchset 3 (id:??) landed as
https://crrev.com/f072c4c56b530b857771e3eea4358ba0daea3c19
Cr-Commit-Position: refs/heads/master@{#426665}