Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2426733004: Bug fix: Use the last hidden time for purge + suspend (Closed)

Created:
4 years, 2 months ago by hajimehoshi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bug fix: Use the last hidden time for purge + suspend |TabStats::last_active| is updated when the tab is made active, and using this as a base time point for purge + suspend is wrong. Instead, the time point should be the time when the tab is made hidden. This CL fixes this by replacing this usage with last_hidden, which is newly introduced. BUG=551995, 607077 Committed: https://crrev.com/c4f226a843d7af20981be69e545f349de5693eae Cr-Commit-Position: refs/heads/master@{#426755}

Patch Set 1 #

Patch Set 2 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/memory/tab_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/memory/tab_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
hajimehoshi
PTAL
4 years, 2 months ago (2016-10-18 09:03:26 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-18 15:14:33 UTC) #4
chrisha
lgtm
4 years, 2 months ago (2016-10-18 21:24:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426733004/1
4 years, 2 months ago (2016-10-19 03:38:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/89478)
4 years, 2 months ago (2016-10-19 03:44:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426733004/20001
4 years, 2 months ago (2016-10-21 06:24:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 09:02:23 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:21 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4f226a843d7af20981be69e545f349de5693eae
Cr-Commit-Position: refs/heads/master@{#426755}

Powered by Google App Engine
This is Rietveld 408576698