Check for blacklist wildcards before creating GURL

Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808
Committed: https://crrev.com/455784dee3dea2a618d4e4d1e6c1003ed55cd6b6
Cr-Commit-Position: refs/heads/master@{#426532}

[brettw, 2016-10-17 20:29:06]

Description was changed from

==========
CHeck for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

BUG=652808
==========

to

==========
Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808
==========

[brettw, 2016-10-17 20:29:06]

brettw@chromium.org changed reviewers:
+ bartfab@chromium.org

[brettw, 2016-10-17 20:29:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 20:29:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 22:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:04:19]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-19 19:34:17]

brettw@chromium.org changed reviewers:
+ pastarmovj@chromium.org
- bartfab@chromium.org

[brettw, 2016-10-19 19:34:18]

timing out -> pastarmovj

[pastarmovj, 2016-10-20 08:54:49]

lgtm. 

One question for you though - what does "timing out -> pastarmovj" mean. At
first I thought you had another reviewer assigned that did not reply in time but
it seems I was the first one :)

[brettw, 2016-10-20 16:34:52]

On 2016/10/20 08:54:49, pastarmovj wrote:
> lgtm. 
> 
> One question for you though - what does "timing out -> pastarmovj" mean. At
> first I thought you had another reviewer assigned that did not reply in time
but
> it seems I was the first one :)

Oh, I had bartfab but I forgot to send mail (!)

[brettw, 2016-10-20 16:48:08]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:48:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:16:12]

Description was changed from

==========
Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808
==========

to

==========
Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808
==========

[commit-bot: I haz the power, 2016-10-20 18:16:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:20:17]

Description was changed from

==========
Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808
==========

to

==========
Check for blacklist wildcards before creating GURL

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808

Committed: https://crrev.com/455784dee3dea2a618d4e4d1e6c1003ed55cd6b6
Cr-Commit-Position: refs/heads/master@{#426532}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:18]

Patchset 1 (id:??) landed as
https://crrev.com/455784dee3dea2a618d4e4d1e6c1003ed55cd6b6
Cr-Commit-Position: refs/heads/master@{#426532}