Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js

Issue 2426723004: ServiceWorker: Modernize postMessage tests for cleanup (Closed)
Patch Set: address review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-to-client.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js
index 4eb14ee1c41337b805f2ce65186b0f8b21219380..7af935f4f8fc01756980e46dcce5018ddc620e67 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js
@@ -3,18 +3,17 @@ self.onmessage = function(e) {
clients.forEach(function(client) {
var messageChannel = new MessageChannel();
messageChannel.port1.onmessage =
- onMessageViaMessagePort.bind(null, client);
- client.postMessage({port: messageChannel.port2},
- [messageChannel.port2]);
+ onMessageViaMessagePort.bind(null, messageChannel.port1);
+ client.postMessage(undefined, [messageChannel.port2]);
});
}));
};
-function onMessageViaMessagePort(client, e) {
+function onMessageViaMessagePort(port, e) {
var message = e.data;
if ('value' in message) {
- client.postMessage({ack: 'Acking value: ' + message.value});
+ port.postMessage({ack: 'Acking value: ' + message.value});
} else if ('done' in message) {
- client.postMessage({done: true});
+ port.postMessage({done: true});
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-to-client.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698