Issue 24267003: Fixing destruction order in password_store_win_unittest.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24267003: Fixing destruction order in password_store_win_unittest.cc (Closed)

Created:
7 years, 3 months ago by mpawlowski

Modified:
7 years, 2 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixing destruction order in password_store_win_unittest.cc The order of declaration now matches the order of initialization in SetUp(). Previously, we would attempt to destroy temp_dir while profile and login_db were still locking it. A very similar fix to https://chromiumcodereview.appspot.com/18684002/ TEST=unit_tests.exe --gtest_filter="PasswordStoreWinTest.*" BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224379

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/password_manager/password_store_win_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpawlowski@opera.com/24267003/1

7 years, 3 months ago (2013-09-20 07:57:20 UTC) #3

Message was sent while issue was closed.

Change committed as 224379

Expand Messages | Collapse Messages