[MD settings] remove count of content items in content settings

[MD settings] remove count of content items in content settings

This CL removes the counter next to Allow, Block, etc in the content
settings site lists. e.g. "Block - 4" is now "Block".

Also, moves categories other than Block and Allow to be located between
Block and Allow in the UI. e.g. Block, Allow, Session Only is now
Block, Session Only, Allow.

BUG=656838
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f4d038a9f9e21fdaf8214370c58fcbed4e0c1c34
Cr-Commit-Position: refs/heads/master@{#426068}

[dschuyler, 2016-10-18 00:46:48]

Description was changed from

==========
[MD settings] remove count of content items in content settings

This CL removes the counter next to Allow, Block, etc in the content
settings site lists. e.g. "Block - 4" is now "Block".

Also, moves categories other than Block and Allow to be located between
Block and Allow in the UI. e.g. Block, Allow, Session Only is now
Block, Session Only, Allow.

BUG=656838
==========

to

==========
[MD settings] remove count of content items in content settings

This CL removes the counter next to Allow, Block, etc in the content
settings site lists. e.g. "Block - 4" is now "Block".

Also, moves categories other than Block and Allow to be located between
Block and Allow in the UI. e.g. Block, Allow, Session Only is now
Block, Session Only, Allow.

BUG=656838
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-18 00:46:50]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 00:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-18 00:47:51]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-18 00:52:06]

i barely understand this voodoo, but lgtm afaict

[commit-bot: I haz the power, 2016-10-18 01:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 01:28:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-10-18 19:07:27]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 19:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-18 19:10:58]

https://chromiumcodereview.appspot.com/2426683003/diff/20001/chrome/test/data...
File chrome/test/data/webui/settings/site_list_tests.js (left):

https://chromiumcodereview.appspot.com/2426683003/diff/20001/chrome/test/data...
chrome/test/data/webui/settings/site_list_tests.js:404: assertEquals('Allow -
0', testElement.$.header.innerText.trim());
I considered shortening these to just test 
that it says 'Allow' (or similar), but then 
that's essentially testing the $i18n{} 
replacement, which I felt was unnecessary here.
Though I'm good with adding them back if that 
would be more useful than I realized.

[Dan Beam, 2016-10-18 19:24:15]

https://chromiumcodereview.appspot.com/2426683003/diff/20001/chrome/test/data...
File chrome/test/data/webui/settings/site_list_tests.js (left):

https://chromiumcodereview.appspot.com/2426683003/diff/20001/chrome/test/data...
chrome/test/data/webui/settings/site_list_tests.js:404: assertEquals('Allow -
0', testElement.$.header.innerText.trim());
On 2016/10/18 19:10:58, dschuyler wrote:
> I considered shortening these to just test 
> that it says 'Allow' (or similar), but then 
> that's essentially testing the $i18n{} 
> replacement, which I felt was unnecessary here.
> Though I'm good with adding them back if that 
> would be more useful than I realized.

nah, just remove, IMO

[commit-bot: I haz the power, 2016-10-18 20:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:25:41]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-18 21:57:50]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-10-18 21:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2426683003/#ps20001
(title: "removed exception counter tests")

[commit-bot: I haz the power, 2016-10-18 21:58:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:11:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:03:56]

Description was changed from

==========
[MD settings] remove count of content items in content settings

This CL removes the counter next to Allow, Block, etc in the content
settings site lists. e.g. "Block - 4" is now "Block".

Also, moves categories other than Block and Allow to be located between
Block and Allow in the UI. e.g. Block, Allow, Session Only is now
Block, Session Only, Allow.

BUG=656838
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove count of content items in content settings

This CL removes the counter next to Allow, Block, etc in the content
settings site lists. e.g. "Block - 4" is now "Block".

Also, moves categories other than Block and Allow to be located between
Block and Allow in the UI. e.g. Block, Allow, Session Only is now
Block, Session Only, Allow.

BUG=656838
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f4d038a9f9e21fdaf8214370c58fcbed4e0c1c34
Cr-Commit-Position: refs/heads/master@{#426068}
==========

[commit-bot: I haz the power, 2016-10-21 13:03:57]

Patchset 2 (id:??) landed as
https://crrev.com/f4d038a9f9e21fdaf8214370c58fcbed4e0c1c34
Cr-Commit-Position: refs/heads/master@{#426068}