third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html - Issue 2426653002: Adding mojo MediaSessionClient to support media controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html

Issue 2426653002: Adding mojo MediaSessionClient to support media controls (Closed)

Patch Set: Addressed haraken's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-reset-handler-notifies-service.html ('K') | « third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-reset-handler-notifies-service.html ('k') | third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-unset-handler-notifies-service.html » ('j') | third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-unset-handler-notifies-service.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>MediaSession Mojo Test</title>

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script src="../../../resources/mojo-helpers.js"></script>

	6 <script src="resources/mediasessionservice-mock.js"></script>

	7 <script src="resources/utils.js"></script>

	8 <script>

	9

	10 var expectations = [

	11 [ 0, true ],

	12 [ 1, true ],

	13 [ 2, true ],

	14 [ 3, true ],

	15 [ 4, true ],

	16 [ 5, true ],

	17 [ 6, true ],

	18 ];

	19

	20 var nextExpectation = 0;

	21

	22 async_test(function(t) {

	23 mediaSessionServiceMock.then(m => {

	24 m.setEnableDisableActionCallback(t.step_func(function(action, isEnabled) {

	25 var expectedAction = expectations[nextExpectation][0];

	26 var expectedIsEnabled = expectations[nextExpectation][1];

	27 assert_equals(expectedAction, action);

	28 assert_equals(expectedIsEnabled, isEnabled);

	29 if (++nextExpectation >= expectations.length)

	30 t.done();

	31 }));

	32

	33 // Unknown function should not be propagated.

	34 window.navigator.mediaSession.onresize = _ => {};

	35 // MediaSession events should be propagated.

	36 window.navigator.mediaSession.onplay = _ => {};

	37 window.navigator.mediaSession.onpause = _ => {};

	38 window.navigator.mediaSession.onplaypause = _ => {};

	39 window.navigator.mediaSession.onprevioustrack = _ => {};

	40 window.navigator.mediaSession.onnexttrack = _ => {};

	41 window.navigator.mediaSession.onseekforward = _ => {};

	42 window.navigator.mediaSession.onseekbackward = _ => {};

	43 });

	44 }, "test that setting event handler notifies the mojo service");
	whywhat 2016/10/18 21:02:57 what's the service of this test if the one above c what's the service of this test if the one above covers the same cases? Zhiqiang Zhang (Slow) 2016/10/19 12:52:06 Merged all the three into one. Show quoted text On 2016/10/18 21:02:57, whywhat wrote: > what's the service of this test if the one above covers the same cases? Merged all the three into one.
	45

	46 </script>

OLD	NEW