chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java - Issue 2426573005: bluetooth-chooser: Refactor and clean up bluetooth chooser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java

Issue 2426573005: bluetooth-chooser: Refactor and clean up bluetooth chooser (Closed)

Patch Set: Address tedchoc's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java

index 08b7dc1fcc6fc3b2daa7da3ae0465d5f48b0e75e..9f589883b807a964c945f0a07e1f24771f599965 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java

@@ -125,14 +125,12 @@ public class UsbChooserDialog implements ItemChooserDialog.ItemSelectedCallback

@VisibleForTesting

@CalledByNative

void addDevice(String deviceId, String deviceName) {

- mItemChooserDialog.addOrUpdateItem(

- new ItemChooserDialog.ItemChooserRow(deviceId, deviceName));

+ mItemChooserDialog.addOrUpdateItem(deviceId, deviceName);

}

@CalledByNative

- private void removeDevice(String deviceId, String deviceName) {

- mItemChooserDialog.removeItemFromList(

- new ItemChooserDialog.ItemChooserRow(deviceId, deviceName));

+ private void removeDevice(String deviceId) {

+ mItemChooserDialog.removeItemFromList(deviceId);

}

@CalledByNative