Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2426573004: Fix Unaccelerated2DGpuCompositing gpu test cases (Closed)

Created:
4 years, 2 months ago by xlai (Olivia)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, f(malita), krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, pdr+graphicswatchlist_chromium.org, blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Unaccelerated2DGpuCompositing gpu test cases TBR=junov@chromium.org BUG=655333 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/97b5ad14320726b53e0da301023cef1ba7818daf Cr-Commit-Position: refs/heads/master@{#426199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
xlai (Olivia)
We may make a mistake when testing the different flags for the bug of content ...
4 years, 2 months ago (2016-10-18 15:48:48 UTC) #3
xlai (Olivia)
4 years, 2 months ago (2016-10-18 15:50:14 UTC) #5
xidachen
lgtm based on the generated reference images.
4 years, 2 months ago (2016-10-18 16:43:19 UTC) #6
Zhenyao Mo
On 2016/10/18 16:43:19, xidachen wrote: > lgtm based on the generated reference images. owner stamp ...
4 years, 2 months ago (2016-10-18 19:27:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426573004/1
4 years, 2 months ago (2016-10-18 19:45:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/245622)
4 years, 2 months ago (2016-10-18 21:28:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426573004/1
4 years, 2 months ago (2016-10-19 14:30:44 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 15:26:18 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:38 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97b5ad14320726b53e0da301023cef1ba7818daf
Cr-Commit-Position: refs/heads/master@{#426199}

Powered by Google App Engine
This is Rietveld 408576698