Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2426553004: Clean up break-inside restriction propagation from table headers. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
rhogan, dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up break-inside restriction propagation from table headers. If a table header has break-inside:avoid, our implementation currently propagates that to all table rows in the table. Make this more obvious (and consistent) with a getPaginationBreakability() override in LayoutTableRow, rather than checking it at only one place (paginationStrutForRow()), although that may very well have been the only place that needed to care. No behavioral changes expected. Committed: https://crrev.com/253f37daa559bcd257cd8e9355fc292280d428fa Cr-Commit-Position: refs/heads/master@{#426020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-18 12:39:40 UTC) #6
eae
LGTM
4 years, 2 months ago (2016-10-18 16:23:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426553004/1
4 years, 2 months ago (2016-10-18 19:10:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 19:18:09 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/253f37daa559bcd257cd8e9355fc292280d428fa
Cr-Commit-Position: refs/heads/master@{#426020}

Powered by Google App Engine
This is Rietveld 408576698