Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2426513003: Refactor LinkStyle out of HTMLLinkElement (Closed)

Created:
4 years, 2 months ago by Yoav Weiss
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor LinkStyle out of HTMLLinkElement BUG= Committed: https://crrev.com/f37493aca7831b1acea7a8af6ca4996c55ab15b7 Cr-Commit-Position: refs/heads/master@{#426179}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -864 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +1 line, -85 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 2 2 chunks +0 lines, -412 lines 0 comments Download
A third_party/WebKit/Source/core/html/LinkStyle.h View 1 chunk +98 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 2 6 chunks +13 lines, -367 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Yoav Weiss
Hey gents :) Link element loading is currently way too messy and needs some love. ...
4 years, 2 months ago (2016-10-17 17:35:18 UTC) #6
kouhei (in TOK)
+toyoshim lgtm % bot failures
4 years, 2 months ago (2016-10-17 21:14:30 UTC) #8
Charlie Harrison
I'll defer to kouhei but this looks good to me too. https://codereview.chromium.org/2426513003/diff/1/third_party/WebKit/Source/core/html/LinkStyle.cpp File third_party/WebKit/Source/core/html/LinkStyle.cpp (left): ...
4 years, 2 months ago (2016-10-17 21:26:35 UTC) #9
Yoav Weiss
Thanks for reviewing! :) https://codereview.chromium.org/2426513003/diff/1/third_party/WebKit/Source/core/html/LinkStyle.cpp File third_party/WebKit/Source/core/html/LinkStyle.cpp (left): https://codereview.chromium.org/2426513003/diff/1/third_party/WebKit/Source/core/html/LinkStyle.cpp#oldcode737 third_party/WebKit/Source/core/html/LinkStyle.cpp:737: DEFINE_TRACE(LinkStyle) { On 2016/10/17 21:26:35, ...
4 years, 2 months ago (2016-10-18 21:03:22 UTC) #15
Takashi Toyoshima
PS3 lgtm
4 years, 2 months ago (2016-10-19 07:45:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426513003/40001
4 years, 2 months ago (2016-10-19 13:42:36 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-19 14:17:43 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:07:57 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f37493aca7831b1acea7a8af6ca4996c55ab15b7
Cr-Commit-Position: refs/heads/master@{#426179}

Powered by Google App Engine
This is Rietveld 408576698