Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2426473007:
[V8][asm.js] Fixes a bug in comma-expression validation. (Closed)
Description[V8][asm.js] Fixes a bug in comma-expression validation.
Comma expressions need to special-handle function calls. When validating
the rhs of a Comma, the validatior needs to ensure that it returns
AsmType::Float() if the function being called is fround().
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528
Committed: https://crrev.com/07ac97835dd21a66658612333f65c7f5ebaaa718
Cr-Commit-Position: refs/heads/master@{#40408}
Patch Set 1 #Patch Set 2 : Ensures that ValidateComma return AsmType::Float() if comma->right() is a call to fround() #Patch Set 3 : expands the tests. #
Messages
Total messages: 32 (24 generated)
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
Description was changed from ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions used special-case the validation of the right operand if that operand was a function call (in which case the whole expression was validated as returning void). This is wrong if the right operand is a call to fround. The fix is to not special-case function calls, and rely on ValidateExpression for rhs validation. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ========== to ========== [V8][asm.js] Fixes a bug in comma-expression validation. ------------------------------------------------------------------------ Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ==========
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jpp@chromium.org
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [V8][asm.js] Fixes a bug in comma-expression validation. ------------------------------------------------------------------------ Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ========== to ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jpp@chromium.org changed reviewers: + aseemgarg@chromium.org, bradnelson@google.com
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bradnelson@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
bradnelson@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ========== to ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 ========== to ========== [V8][asm.js] Fixes a bug in comma-expression validation. Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 Committed: https://crrev.com/07ac97835dd21a66658612333f65c7f5ebaaa718 Cr-Commit-Position: refs/heads/master@{#40408} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/07ac97835dd21a66658612333f65c7f5ebaaa718 Cr-Commit-Position: refs/heads/master@{#40408} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
