Remove some linked_ptr from /content

Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/85735f4dfb9d59b08fe0d724cf26a1bb51ce837d
Cr-Commit-Position: refs/heads/master@{#426695}

[limasdf, 2016-10-19 16:28:53]

The CQ bit was checked by limasdf@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 16:29:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[limasdf, 2016-10-19 17:10:50]

Description was changed from

==========
Remove linked_ptr from browser_plugin_guest.h/cc

BUG=
==========

to

==========
Remove some linked_ptr from /content

BUG=556939
==========

[limasdf, 2016-10-19 17:10:50]

limasdf@gmail.com changed reviewers:
+ avi@chromium.org

[limasdf, 2016-10-19 17:11:42]

Description was changed from

==========
Remove some linked_ptr from /content

BUG=556939
==========

to

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unnecessary linked_ptr.h 

BUG=556939
==========

[limasdf, 2016-10-19 17:13:55]

Avi, Could you take a look when you find a time?

[limasdf, 2016-10-19 17:18:49]

Description was changed from

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unnecessary linked_ptr.h 

BUG=556939
==========

to

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
==========

[Avi (use Gerrit), 2016-10-19 18:08:24]

:\

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:567: return
msg.release();
What?

It makes little sense to have the parameter be a properly owning pointer but
make the return value unowned-yet-owning.

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:572: return
msg.release();
ditto

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:592: return
new_msg.release();
All paths out of this function return a unique_ptr but call .release() on it.
Modify this function to return the unique_ptr then.

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.h (right):

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.h:385:
std::unique_ptr<IPC::Message> msg) const;
This function prototype looks wrong for the comment.

It talks about returning the input message, but the input message is an owning
pointer but the returned value is unowned.

[Avi (use Gerrit), 2016-10-19 18:10:32]

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:496: void
BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
Does it make sense, rather than doing a WrapUnique below, to make this function
take an owning pointer?

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:603:
SendMessageToEmbedder(UpdateInstanceIdIfNecessary(std::move(message_ptr)));
And it all comes together here. Have UpdateInstanceIdIfNecessary return an owned
pointer, have SendMessageToEmbedder take an owned pointer, and boom we're good.

[limasdf, 2016-10-20 12:06:47]

Description was changed from

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
==========

to

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[limasdf, 2016-10-20 12:09:02]

Thanks for the reivew. PTAL.

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:592: return
new_msg.release();
On 2016/10/19 18:08:23, Avi wrote:
> All paths out of this function return a unique_ptr but call .release() on it.
> Modify this function to return the unique_ptr then.

Done.

https://codereview.chromium.org/2426423004/diff/20001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:603:
SendMessageToEmbedder(UpdateInstanceIdIfNecessary(std::move(message_ptr)));
On 2016/10/19 18:10:32, Avi wrote:
> And it all comes together here. Have UpdateInstanceIdIfNecessary return an
owned
> pointer, have SendMessageToEmbedder take an owned pointer, and boom we're
good.

Done.

[Avi (use Gerrit), 2016-10-20 15:08:12]

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:221:
SendMessageToEmbedder(base::WrapUnique(new BrowserPluginMsg_SetTooltipText(
SendMessageToEmbedder(base::MakeUnique<BrowserPluginMsg_SetTooltipText>(browser_plugin_instance_id_,
tooltip_text));

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:398: new
BrowserPluginMsg_SetMouseLock(browser_plugin_instance_id(), allow)));
base::MakeUnique here too

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:408: base::WrapUnique(new
BrowserPluginMsg_SetChildFrameSurface(
base::MakeUnique here too

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:649: new
BrowserPluginMsg_GuestReady(browser_plugin_instance_id())));
MakeUnique

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:659: new
BrowserPluginMsg_GuestGone(browser_plugin_instance_id())));
MakeUnique

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:961: new
BrowserPluginMsg_SetMouseLock(browser_plugin_instance_id(), false)));
MakeUnique

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:984:
browser_plugin_instance_id(), accept)));
MakeUnique

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:1012:
SendMessageToEmbedder(base::WrapUnique(new BrowserPluginMsg_AdvanceFocus(
MakeUnique

https://codereview.chromium.org/2426423004/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.cc:410:
base::WrapUnique(new BrowserPluginMsg_SetCursor(
MakeUnique

[limasdf, 2016-10-20 15:56:20]

WrapUnique -> MakeUnique
- Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:221:
SendMessageToEmbedder(base::WrapUnique(new BrowserPluginMsg_SetTooltipText(
On 2016/10/20 15:08:12, Avi wrote:
>
SendMessageToEmbedder(base::MakeUnique<BrowserPluginMsg_SetTooltipText>(browser_plugin_instance_id_,
> tooltip_text));

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:398: new
BrowserPluginMsg_SetMouseLock(browser_plugin_instance_id(), allow)));
On 2016/10/20 15:08:12, Avi wrote:
> base::MakeUnique here too

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:408: base::WrapUnique(new
BrowserPluginMsg_SetChildFrameSurface(
On 2016/10/20 15:08:12, Avi wrote:
> base::MakeUnique here too

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:649: new
BrowserPluginMsg_GuestReady(browser_plugin_instance_id())));
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:659: new
BrowserPluginMsg_GuestGone(browser_plugin_instance_id())));
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:961: new
BrowserPluginMsg_SetMouseLock(browser_plugin_instance_id(), false)));
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:984:
browser_plugin_instance_id(), accept)));
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/browser...
content/browser/browser_plugin/browser_plugin_guest.cc:1012:
SendMessageToEmbedder(base::WrapUnique(new BrowserPluginMsg_AdvanceFocus(
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

https://codereview.chromium.org/2426423004/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/2426423004/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.cc:410:
base::WrapUnique(new BrowserPluginMsg_SetCursor(
On 2016/10/20 15:08:12, Avi wrote:
> MakeUnique

Done.

[Avi (use Gerrit), 2016-10-20 18:33:06]

lgtm

👍

[limasdf, 2016-10-21 00:08:16]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-10-21 00:09:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 02:25:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:26:18]

Description was changed from

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove some linked_ptr from /content

- Remove linked_ptr from content/browser/browser_plugin/browser_plugin_guest.cc
- Remove unused linked_ptr.h includes.

BUG=556939
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/85735f4dfb9d59b08fe0d724cf26a1bb51ce837d
Cr-Commit-Position: refs/heads/master@{#426695}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:19]

Patchset 4 (id:??) landed as
https://crrev.com/85735f4dfb9d59b08fe0d724cf26a1bb51ce837d
Cr-Commit-Position: refs/heads/master@{#426695}