Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2426343005: Revert "Revert "remove unneeded flags for android"" (Closed)

Created:
4 years, 2 months ago by reed1
Modified:
4 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Revert "remove unneeded flags for android"" This reverts commit bbe17a66705aff6f34a22adc0c12883dcb6161b3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426343005 Committed: https://skia.googlesource.com/skia/+/f4ace0124f408aa52d111f6ed30ac80833d00c9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reed1
4 years, 2 months ago (2016-10-19 21:17:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426343005/1
4 years, 2 months ago (2016-10-19 21:17:23 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 2 months ago (2016-10-19 21:17:24 UTC) #6
msarett
lgtm
4 years, 2 months ago (2016-10-19 21:18:49 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 21:38:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f4ace0124f408aa52d111f6ed30ac80833d00c9a

Powered by Google App Engine
This is Rietveld 408576698