Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2426343003: Fix for roll_webrtc after SVN support was dropped from depot tools (Closed)

Created:
4 years, 2 months ago by o1ka
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for roll_webrtc after SVN support was dropped from depot tools See also https://codereview.webrtc.org/2425923002 BUG=657332 Committed: https://crrev.com/7d8e3f86df86dff02ea2ed1c8a5c850f09cbd936 Cr-Commit-Position: refs/heads/master@{#426151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/roll_webrtc.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
o1ka
PTAL
4 years, 2 months ago (2016-10-19 10:47:39 UTC) #2
kjellander_chromium
lgtm how come you didn't use https://codereview.chromium.org for the review?
4 years, 2 months ago (2016-10-19 10:50:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426343003/1
4 years, 2 months ago (2016-10-19 10:54:09 UTC) #5
o1ka
On 2016/10/19 10:50:50, kjellander_chromium wrote: > lgtm > > how come you didn't use https://codereview.chromium.org ...
4 years, 2 months ago (2016-10-19 10:55:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 11:44:22 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:07:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d8e3f86df86dff02ea2ed1c8a5c850f09cbd936
Cr-Commit-Position: refs/heads/master@{#426151}

Powered by Google App Engine
This is Rietveld 408576698