Invalidate properties registered as non-inherited for custom paint

Invalidate properties registered as non-inherited for custom paint

This patch fixes custom paint invalidation for properties registered as
non-inherited. To avoid plumbing the property registry around more, we
check both the StyleInheritedVariables and StyleNonInheritedVariables
to get a custom property's value.

The invalidation for registered properties is not 100% precise as we
compare the token stream values instead of parsed values, so a value
could change representation (e.g. 160px to 10em) without a change in
computation value and we would still invalidate.

We also fail to invalidate when a property is registered. This could
result in a computed value being set to the initial value. Alternatively
the value could remain the same but registration could cause the value
returned in the FilteredComputedStylePropertyMap to no longer be an
unparsed value.

BUG=641877
Committed: https://crrev.com/656fac63623b571cf135de0f5fe0e904f984b26a
Cr-Commit-Position: refs/heads/master@{#426421}

[Timothy Loh, 2016-10-19 05:09:25]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 05:10:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-10-19 05:17:38]

timloh@chromium.org changed reviewers:
+ ikilpatrick@chromium.org, meade@chromium.org

[Timothy Loh, 2016-10-19 05:17:39]

I'll file a bug later for the last issue mentioned in the description...

[meade_UTC10, 2016-10-19 07:41:14]

lgtm

Seems fine to me. Not sure I understand the custom paint things though.

https://codereview.chromium.org/2426323003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2426323003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1022:
other.inheritedVariables() || other.nonInheritedVariables()) {
There are variables that aren't inherited or non-inherited? It sounds like this
should be run every time if there is a variable at all?

[commit-bot: I haz the power, 2016-10-19 13:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 13:27:15]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2016-10-19 16:08:30]

lgtm

[Timothy Loh, 2016-10-20 06:05:17]

https://codereview.chromium.org/2426323003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2426323003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1022:
other.inheritedVariables() || other.nonInheritedVariables()) {
On 2016/10/19 07:41:14, Eddy wrote:
> There are variables that aren't inherited or non-inherited? It sounds like
this
> should be run every time if there is a variable at all?

There's just no function right now that checks whether there are any custom
properties set since it's only used for early-out optimisations like this.

[Timothy Loh, 2016-10-20 06:05:23]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-10-20 06:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 06:27:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:16:17]

Description was changed from

==========
Invalidate properties registered as non-inherited for custom paint

This patch fixes custom paint invalidation for properties registered as
non-inherited. To avoid plumbing the property registry around more, we
check both the StyleInheritedVariables and StyleNonInheritedVariables
to get a custom property's value.

The invalidation for registered properties is not 100% precise as we
compare the token stream values instead of parsed values, so a value
could change representation (e.g. 160px to 10em) without a change in
computation value and we would still invalidate.

We also fail to invalidate when a property is registered. This could
result in a computed value being set to the initial value. Alternatively
the value could remain the same but registration could cause the value
returned in the FilteredComputedStylePropertyMap to no longer be an
unparsed value.

BUG=641877
==========

to

==========
Invalidate properties registered as non-inherited for custom paint

This patch fixes custom paint invalidation for properties registered as
non-inherited. To avoid plumbing the property registry around more, we
check both the StyleInheritedVariables and StyleNonInheritedVariables
to get a custom property's value.

The invalidation for registered properties is not 100% precise as we
compare the token stream values instead of parsed values, so a value
could change representation (e.g. 160px to 10em) without a change in
computation value and we would still invalidate.

We also fail to invalidate when a property is registered. This could
result in a computed value being set to the initial value. Alternatively
the value could remain the same but registration could cause the value
returned in the FilteredComputedStylePropertyMap to no longer be an
unparsed value.

BUG=641877

Committed: https://crrev.com/656fac63623b571cf135de0f5fe0e904f984b26a
Cr-Commit-Position: refs/heads/master@{#426421}
==========

[commit-bot: I haz the power, 2016-10-21 13:16:18]

Patchset 1 (id:??) landed as
https://crrev.com/656fac63623b571cf135de0f5fe0e904f984b26a
Cr-Commit-Position: refs/heads/master@{#426421}