Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2426233002: s390x: [wasm] Adding r3 to GP return register list (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390x: [wasm] Adding r3 to GP return register list Taking similar approach as ia32 which also has 1 return register eax (as per ia32's ABI) but uses edx as return register as well. This will fix some failures on s390x where a function returns 2 values. R=titzer@chromium.org, bmeurer@chromium.org BUG= LOG=N Committed: https://crrev.com/91c99de0a10db4d8ffa4cac8a701eef7dab22c44 Cr-Commit-Position: refs/heads/master@{#40439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/wasm-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
ptal
4 years, 2 months ago (2016-10-18 23:55:08 UTC) #1
titzer
lgtm
4 years, 2 months ago (2016-10-19 05:33:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426233002/1
4 years, 2 months ago (2016-10-19 13:13:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 13:48:09 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91c99de0a10db4d8ffa4cac8a701eef7dab22c44
Cr-Commit-Position: refs/heads/master@{#40439}

Powered by Google App Engine
This is Rietveld 408576698