content/browser/accessibility/dump_accessibility_events_browsertest.cc - Issue 2426193003: Re-land: Create AXAction and AXActionData as a way to simplify accessibility actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_events_browsertest.cc

Issue 2426193003: Re-land: Create AXAction and AXActionData as a way to simplify accessibility actions (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_unittest.cc ('k') | content/browser/accessibility/hit_testing_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_events_browsertest.cc

diff --git a/content/browser/accessibility/dump_accessibility_events_browsertest.cc b/content/browser/accessibility/dump_accessibility_events_browsertest.cc

index b81c4ac4ccef9afe00faf174907ed4cf7e80f31e..28daec1a00603bd27f76908284e2547065e73bdf 100644

--- a/content/browser/accessibility/dump_accessibility_events_browsertest.cc

+++ b/content/browser/accessibility/dump_accessibility_events_browsertest.cc

@@ -93,7 +93,6 @@ std::vector<std::string> DumpAccessibilityEventsTest::Dump() {

waiter.reset(new AccessibilityNotificationWaiter(

shell()->web_contents(), AccessibilityModeComplete, ui::AX_EVENT_NONE));

web_contents->GetMainFrame()->ExecuteJavaScriptForTests(

base::ASCIIToUTF16("go()"));

@@ -109,7 +108,7 @@ std::vector<std::string> DumpAccessibilityEventsTest::Dump() {

shell()->web_contents(), AccessibilityModeComplete, ui::AX_EVENT_HOVER));

BrowserAccessibilityManager* manager =

web_contents->GetRootBrowserAccessibilityManager();

- manager->delegate()->AccessibilityHitTest(gfx::Point(0, 0));

+ manager->HitTest(gfx::Point(0, 0));

waiter->WaitForNotification();

// Save a copy of the final accessibility tree (as a text dump); we'll