Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2426193003: Re-land: Create AXAction and AXActionData as a way to simplify accessibility actions (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index c844cdb09abb09cb113faab19f84abbb7570f3a6..bc9eea0357372ab1754015d3a4d438ac708cc3a0 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -2796,14 +2796,13 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
return;
// TODO(dmazzoni): Support more actions.
+ BrowserAccessibilityManager* manager = browserAccessibility_->manager();
if ([action isEqualToString:NSAccessibilityPressAction]) {
- [self delegate]->AccessibilityDoDefaultAction(
- browserAccessibility_->GetId());
+ manager->DoDefaultAction(*browserAccessibility_);
} else if ([action isEqualToString:NSAccessibilityShowMenuAction]) {
- [self delegate]->AccessibilityShowContextMenu(
- browserAccessibility_->GetId());
+ manager->ShowContextMenu(*browserAccessibility_);
} else if ([action isEqualToString:NSAccessibilityScrollToVisibleAction]) {
- browserAccessibility_->manager()->ScrollToMakeVisible(
+ manager->ScrollToMakeVisible(
*browserAccessibility_, gfx::Rect());
}
}
@@ -2839,9 +2838,9 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
}
if ([attribute isEqualToString:NSAccessibilitySelectedTextRangeAttribute]) {
NSRange range = [(NSValue*)value rangeValue];
- [self delegate]->AccessibilitySetSelection(
- browserAccessibility_->GetId(), range.location,
- browserAccessibility_->GetId(), range.location + range.length);
+ BrowserAccessibilityManager* manager = browserAccessibility_->manager();
+ manager->SetTextSelection(
+ *browserAccessibility_, range.location, range.location + range.length);
}
}

Powered by Google App Engine
This is Rietveld 408576698