Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2425983002: [turbofan] Use uint32 to store the number of control outputs instead of uint16. (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use uint32 to store the number of control outputs instead of uint16. Using uint32 to store the the number of control outputs allows WebAssembly switches to have more than 2^16 case. BUG=v8:5531 TEST=mjsunit/regress/wasm/regression-5531 R=titzer@chromium.org Committed: https://crrev.com/2f3ca961c7bd525dd8aac3540d3b5b692b259a2b Cr-Commit-Position: refs/heads/master@{#40420}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Increase the maximum number of control outputs instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/compiler/operator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
A + test/mjsunit/regress/wasm/regression-5531.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
ahaas
4 years, 2 months ago (2016-10-18 11:35:46 UTC) #1
titzer
https://codereview.chromium.org/2425983002/diff/1/src/wasm/ast-decoder.h File src/wasm/ast-decoder.h (right): https://codereview.chromium.org/2425983002/diff/1/src/wasm/ast-decoder.h#newcode225 src/wasm/ast-decoder.h:225: if (table_count > Can we instead fix the TurboFan ...
4 years, 2 months ago (2016-10-18 12:34:07 UTC) #6
ahaas
On 2016/10/18 at 12:34:07, titzer wrote: > https://codereview.chromium.org/2425983002/diff/1/src/wasm/ast-decoder.h > File src/wasm/ast-decoder.h (right): > > https://codereview.chromium.org/2425983002/diff/1/src/wasm/ast-decoder.h#newcode225 ...
4 years, 2 months ago (2016-10-18 13:02:32 UTC) #11
titzer
lgtm
4 years, 2 months ago (2016-10-18 13:03:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425983002/20001
4 years, 2 months ago (2016-10-19 07:11:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 07:25:24 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f3ca961c7bd525dd8aac3540d3b5b692b259a2b
Cr-Commit-Position: refs/heads/master@{#40420}

Powered by Google App Engine
This is Rietveld 408576698