[debugger] basic test infrastructure for new debugger test api.

[debugger] basic test infrastructure for new debugger test api.

This introduces:
- a way in d8 to send messages to the inspector and receive responses.
- a new test suite where existing debugger tests should migrate to.

R=jgruber@chromium.org, kozyatinskiy@chromium.org, machenbach@chromium.org
BUG=v8:5530
Committed: https://crrev.com/2f135d464c091eafb45c0bc4a597e3f1c9540676
Cr-Commit-Position: refs/heads/master@{#40487}

[kozy, 2016-10-19 02:53:24]

lgtm

[jgruber, 2016-10-19 07:33:03]

lgtm with comments

https://chromiumcodereview.appspot.com/2425973002/diff/20001/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/2425973002/diff/20001/src/d8.cc#newcod...
src/d8.cc:1828: context->SetAlignedPointerInEmbedderData(kInspectorClientIndex,
this);
Just curious - why aren't we using a standard singleton pattern to store the
InspectorClient instance?

https://chromiumcodereview.appspot.com/2425973002/diff/20001/src/d8.cc#newcod...
src/d8.cc:1830: v8_inspector::V8ContextInfo(context, 1,
v8_inspector::StringView()));
Please add a named constant to replace the 1 for the contextGroupId here and
above.

https://chromiumcodereview.appspot.com/2425973002/diff/20001/src/d8.cc#newcod...
src/d8.cc:1845: static v8_inspector::V8InspectorSession*
GetSession(Local<Context> context) {
Could this be private?

[Michael Achenbach, 2016-10-19 11:21:39]

lgtm on build and test config changes with comment:

https://codereview.chromium.org/2425973002/diff/20001/test/debugger/testcfg.py
File test/debugger/testcfg.py (right):

https://codereview.chromium.org/2425973002/diff/20001/test/debugger/testcfg.p...
test/debugger/testcfg.py:42: files.append(os.path.join(self.root,
"../mjsunit/mjsunit.js"))
os.path.normpath(os.path.join(self.root, "..", "mjsunit", "mjsunit.js"))

[Yang, 2016-10-20 07:24:13]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-10-20 07:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2425973002/#ps40001
(title: "address comments.")

[commit-bot: I haz the power, 2016-10-20 07:24:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-10-20 07:29:30]

https://codereview.chromium.org/2425973002/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2425973002/diff/20001/src/d8.cc#newcode1828
src/d8.cc:1828: context->SetAlignedPointerInEmbedderData(kInspectorClientIndex,
this);
On 2016/10/19 07:33:03, jgruber wrote:
> Just curious - why aren't we using a standard singleton pattern to store the
> InspectorClient instance?

d8 can run with --isolate option, in which case we have two separate isolates
running the same test in two different threads. Using a singleton would likely
break in this scenario.

https://codereview.chromium.org/2425973002/diff/20001/src/d8.cc#newcode1830
src/d8.cc:1830: v8_inspector::V8ContextInfo(context, 1,
v8_inspector::StringView()));
On 2016/10/19 07:33:03, jgruber wrote:
> Please add a named constant to replace the 1 for the contextGroupId here and
> above.

Done.

https://codereview.chromium.org/2425973002/diff/20001/src/d8.cc#newcode1845
src/d8.cc:1845: static v8_inspector::V8InspectorSession*
GetSession(Local<Context> context) {
On 2016/10/19 07:33:03, jgruber wrote:
> Could this be private?

Done.

https://codereview.chromium.org/2425973002/diff/20001/test/debugger/testcfg.py
File test/debugger/testcfg.py (right):

https://codereview.chromium.org/2425973002/diff/20001/test/debugger/testcfg.p...
test/debugger/testcfg.py:42: files.append(os.path.join(self.root,
"../mjsunit/mjsunit.js"))
On 2016/10/19 11:21:38, machenbach (slow) wrote:
> os.path.normpath(os.path.join(self.root, "..", "mjsunit", "mjsunit.js"))

Done.

[commit-bot: I haz the power, 2016-10-20 07:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 07:34:41]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2016-10-20 07:59:07]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-10-20 07:59:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2425973002/#ps60001
(title: "compile fix")

[commit-bot: I haz the power, 2016-10-20 07:59:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 08:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:01:57]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/16452)

[Yang, 2016-10-20 09:32:04]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 09:32:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 09:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 09:56:22]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-21 06:29:59]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-10-21 06:30:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2425973002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-10-21 06:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:37:37]

Committed patchset #5 (id:80001)

[Michael Achenbach, 2016-11-07 14:42:05]

https://codereview.chromium.org/2425973002/diff/80001/test/debugger/debugger....
File test/debugger/debugger.isolate (right):

https://codereview.chromium.org/2425973002/diff/80001/test/debugger/debugger....
test/debugger/debugger.isolate:10: './debugger.status',
jgruber is on it:
Better use ./ to include further directories.

[commit-bot: I haz the power, 2016-11-17 22:08:58]

Description was changed from

==========
[debugger] basic test infrastructure for new debugger test api.

This introduces:
- a way in d8 to send messages to the inspector and receive responses.
- a new test suite where existing debugger tests should migrate to.

R=jgruber@chromium.org, kozyatinskiy@chromium.org, machenbach@chromium.org
BUG=v8:5530
==========

to

==========
[debugger] basic test infrastructure for new debugger test api.

This introduces:
- a way in d8 to send messages to the inspector and receive responses.
- a new test suite where existing debugger tests should migrate to.

R=jgruber@chromium.org, kozyatinskiy@chromium.org, machenbach@chromium.org
BUG=v8:5530

Committed: https://crrev.com/2f135d464c091eafb45c0bc4a597e3f1c9540676
Cr-Commit-Position: refs/heads/master@{#40487}
==========

[commit-bot: I haz the power, 2016-11-17 22:08:59]

Patchset 5 (id:??) landed as
https://crrev.com/2f135d464c091eafb45c0bc4a597e3f1c9540676
Cr-Commit-Position: refs/heads/master@{#40487}