Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2425943002: Mojofy unittests: ServiceWorkerHandleTest (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojofy unittests: ServiceWorkerHandleTest This patch mojofies ServiceWorkerHandleTest by using MojoServiceWorkerTestP. BUG=629701 TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerHandleTest*" Committed: https://crrev.com/5ec0988476e186dff4c97085f331b481a71c0a3d Cr-Commit-Position: refs/heads/master@{#426130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M content/browser/service_worker/service_worker_handle_unittest.cc View 2 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shimazu
ptal
4 years, 2 months ago (2016-10-18 09:57:40 UTC) #2
horo
lgtm
4 years, 2 months ago (2016-10-19 01:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425943002/1
4 years, 2 months ago (2016-10-19 02:16:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 04:09:49 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ec0988476e186dff4c97085f331b481a71c0a3d
Cr-Commit-Position: refs/heads/master@{#426130}

Powered by Google App Engine
This is Rietveld 408576698