Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2425873005: Don't apply clips to children of composited-scrolling elements for overlap testing. (Closed)
Patch Set: none Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index bee31e4f8dfcb800807fbfae8e6654e4ddaaacf1..b7d4b8c22446a55db390781615d6940e9e1368d0 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -148,20 +148,22 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
if (!layer->isRootLayer()) {
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- properties.clippedAbsoluteBoundingBox =
+ properties.unclippedAbsoluteBoundingBox =
enclosingIntRect(m_geometryMap.absoluteRect(
FloatRect(layer->boundingBoxForCompositingOverlapTest())));
// FIXME: Setting the absBounds to 1x1 instead of 0x0 makes very little
// sense, but removing this code will make JSGameBench sad.
// See https://codereview.chromium.org/13912020/
- if (properties.clippedAbsoluteBoundingBox.isEmpty())
- properties.clippedAbsoluteBoundingBox.setSize(IntSize(1, 1));
+ if (properties.unclippedAbsoluteBoundingBox.isEmpty())
+ properties.unclippedAbsoluteBoundingBox.setSize(IntSize(1, 1));
IntRect clipRect =
pixelSnappedIntRect(layer->clipper()
.backgroundClipRect(ClipRectsContext(
m_rootLayer, AbsoluteClipRects))
.rect());
+ properties.clippedAbsoluteBoundingBox =
+ properties.unclippedAbsoluteBoundingBox;
properties.clippedAbsoluteBoundingBox.intersect(clipRect);
}

Powered by Google App Engine
This is Rietveld 408576698