Don't apply clips to children of composited-scrolling elements for overlap testing.

third_party/WebKit/Source/core/paint/PaintLayer.h

 /*
  * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
@@ skipping 64 matching lines @@
 class PaintTiming;
 class TransformationMatrix;
 
 enum IncludeSelfOrNot { IncludeSelf, ExcludeSelf };
 
 enum CompositingQueryMode {
   CompositingQueriesAreAllowed,
   CompositingQueriesAreOnlyAllowedInCertainDocumentLifecyclePhases
 };
 
-// FIXME: remove this once the compositing query ASSERTS are no longer hit.
+// FIXME: remove this once the compositing query DCHECKS are no longer hit.
 class CORE_EXPORT DisableCompositingQueryAsserts {
   STACK_ALLOCATED();
   WTF_MAKE_NONCOPYABLE(DisableCompositingQueryAsserts);
 
  public:
   DisableCompositingQueryAsserts();
 
  private:
   AutoReset<CompositingQueryMode> m_disabler;
 };
@@ skipping 165 matching lines @@
   }
 
   const PaintLayer* root() const {
     const PaintLayer* curr = this;
     while (curr->parent())
       curr = curr->parent();
     return curr;
   }
 
   const LayoutPoint& location() const {
-    ASSERT(!m_needsPositionUpdate);
+#if DCHECK_IS_ON()
+    DCHECK(!m_needsPositionUpdate);
+#endif
     return m_location;
   }
-  // FIXME: size() should ASSERT(!m_needsPositionUpdate) as well, but that fails
+  // FIXME: size() should DCHECK(!m_needsPositionUpdate) as well, but that fails
   // in some tests, for example, fast/repaint/clipped-relative.html.
   const IntSize& size() const { return m_size; }
   void setSizeHackForLayoutTreeAsText(const IntSize& size) { m_size = size; }
 
   LayoutRect rect() const { return LayoutRect(location(), LayoutSize(size())); }
 
   bool isRootLayer() const { return m_isRootLayer; }
 
   PaintLayerCompositor* compositor() const;
 
@@ skipping 334 matching lines @@
                              RuntimeEnabledFeatures::slimmingPaintV2Enabled());
   }
 
   bool scrollsOverflow() const;
 
   CompositingReasons potentialCompositingReasonsFromStyle() const {
     return m_rareData ? m_rareData->potentialCompositingReasonsFromStyle
                       : CompositingReasonNone;
   }
   void setPotentialCompositingReasonsFromStyle(CompositingReasons reasons) {
-    ASSERT(reasons ==
+    DCHECK(reasons ==
            (reasons & CompositingReasonComboAllStyleDeterminedReasons));
     if (m_rareData || reasons != CompositingReasonNone)
       ensureRareData().potentialCompositingReasonsFromStyle = reasons;
   }
 
   bool hasStyleDeterminedDirectCompositingReasons() const {
     return potentialCompositingReasonsFromStyle() &
            CompositingReasonComboAllDirectStyleDeterminedReasons;
   }
 
   class AncestorDependentCompositingInputs {
     DISALLOW_NEW();
 
    public:
     AncestorDependentCompositingInputs() : clippingContainer(nullptr) {}
 
     IntRect clippedAbsoluteBoundingBox;
+    IntRect unclippedAbsoluteBoundingBox;
     const LayoutObject* clippingContainer;
   };
 
   class RareAncestorDependentCompositingInputs {
    public:
     RareAncestorDependentCompositingInputs()
         : opacityAncestor(nullptr),
           transformAncestor(nullptr),
           filterAncestor(nullptr),
           ancestorScrollingLayer(nullptr),
@@ skipping 33 matching lines @@
     const PaintLayer* clipParent;
   };
 
   void setNeedsCompositingInputsUpdate();
   bool childNeedsCompositingInputsUpdate() const {
     return m_childNeedsCompositingInputsUpdate;
   }
   bool needsCompositingInputsUpdate() const {
     // While we're updating the compositing inputs, these values may differ.
     // We should never be asking for this value when that is the case.
-    ASSERT(m_needsDescendantDependentCompositingInputsUpdate ==
+    DCHECK(m_needsDescendantDependentCompositingInputsUpdate ==
            m_needsAncestorDependentCompositingInputsUpdate);
     return m_needsDescendantDependentCompositingInputsUpdate;
   }
 
   void updateAncestorOverflowLayer(const PaintLayer* ancestorOverflowLayer) {
     m_ancestorOverflowLayer = ancestorOverflowLayer;
   }
   void updateAncestorDependentCompositingInputs(
       const AncestorDependentCompositingInputs&,
       const RareAncestorDependentCompositingInputs&,
       bool hasAncestorWithClipPath);
   void updateDescendantDependentCompositingInputs(
       bool hasDescendantWithClipPath,
       bool hasNonIsolatedDescendantWithBlendMode,
       bool hasRootScrollerAsDescendant);
   void didUpdateCompositingInputs();
 
   IntRect clippedAbsoluteBoundingBox() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_ancestorDependentCompositingInputs.clippedAbsoluteBoundingBox;
   }
+  IntRect unclippedAbsoluteBoundingBox() const {
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
+    return m_ancestorDependentCompositingInputs.unclippedAbsoluteBoundingBox;
+  }
   const PaintLayer* opacityAncestor() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs->opacityAncestor
                : nullptr;
   }
   const PaintLayer* transformAncestor() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs->transformAncestor
                : nullptr;
   }
   const PaintLayer* filterAncestor() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs->filterAncestor
                : nullptr;
   }
   const LayoutObject* clippingContainer() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_ancestorDependentCompositingInputs.clippingContainer;
   }
   const PaintLayer* ancestorOverflowLayer() const {
     return m_ancestorOverflowLayer;
   }
   const PaintLayer* ancestorScrollingLayer() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs
                      ->ancestorScrollingLayer
                : nullptr;
   }
   const PaintLayer* nearestFixedPositionLayer() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs
                      ->nearestFixedPositionLayer
                : nullptr;
   }
   const PaintLayer* scrollParent() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs->scrollParent
                : nullptr;
   }
   const PaintLayer* clipParent() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_rareAncestorDependentCompositingInputs
                ? m_rareAncestorDependentCompositingInputs->clipParent
                : nullptr;
   }
   bool hasAncestorWithClipPath() const {
-    ASSERT(!m_needsAncestorDependentCompositingInputsUpdate);
+    DCHECK(!m_needsAncestorDependentCompositingInputsUpdate);
     return m_hasAncestorWithClipPath;
   }
   bool hasDescendantWithClipPath() const {
-    ASSERT(!m_needsDescendantDependentCompositingInputsUpdate);
+    DCHECK(!m_needsDescendantDependentCompositingInputsUpdate);
     return m_hasDescendantWithClipPath;
   }
   bool hasNonIsolatedDescendantWithBlendMode() const;
 
   bool hasRootScrollerAsDescendant() const {
-    ASSERT(!m_needsDescendantDependentCompositingInputsUpdate);
+    DCHECK(!m_needsDescendantDependentCompositingInputsUpdate);
     return m_hasRootScrollerAsDescendant;
   }
 
   bool lostGroupedMapping() const {
-    ASSERT(isAllowedToQueryCompositingState());
+    DCHECK(isAllowedToQueryCompositingState());
     return m_lostGroupedMapping;
   }
   void setLostGroupedMapping(bool b) { m_lostGroupedMapping = b; }
 
   CompositingReasons getCompositingReasons() const {
-    ASSERT(isAllowedToQueryCompositingState());
+    DCHECK(isAllowedToQueryCompositingState());
     return m_rareData ? m_rareData->compositingReasons : CompositingReasonNone;
   }
   void setCompositingReasons(CompositingReasons,
                              CompositingReasons mask = CompositingReasonAll);
 
   SquashingDisallowedReasons getSquashingDisallowedReasons() const {
-    ASSERT(isAllowedToQueryCompositingState());
+    DCHECK(isAllowedToQueryCompositingState());
     return m_rareData ? m_rareData->squashingDisallowedReasons
                       : SquashingDisallowedReasonsNone;
   }
   void setSquashingDisallowedReasons(SquashingDisallowedReasons);
 
   bool hasCompositingDescendant() const {
-    ASSERT(isAllowedToQueryCompositingState());
+    DCHECK(isAllowedToQueryCompositingState());
     return m_hasCompositingDescendant;
   }
   void setHasCompositingDescendant(bool);
 
   bool shouldIsolateCompositedDescendants() const {
-    ASSERT(isAllowedToQueryCompositingState());
+    DCHECK(isAllowedToQueryCompositingState());
     return m_shouldIsolateCompositedDescendants;
   }
   void setShouldIsolateCompositedDescendants(bool);
 
   void updateDescendantDependentFlags();
 
   void updateOrRemoveFilterEffect();
 
   void updateSelfPaintingLayer();
   // This is O(depth) so avoid calling this in loops. Instead use optimizations
   // like those in PaintInvalidationState.
   PaintLayer* enclosingSelfPaintingLayer();
 
   PaintLayer* enclosingTransformedAncestor() const;
   LayoutPoint computeOffsetFromTransformedAncestor() const;
 
   void didUpdateNeedsCompositedScrolling();
 
   bool hasSelfPaintingLayerDescendant() const {
     if (m_hasSelfPaintingLayerDescendantDirty)
       updateHasSelfPaintingLayerDescendant();
-    ASSERT(!m_hasSelfPaintingLayerDescendantDirty);
+    DCHECK(!m_hasSelfPaintingLayerDescendantDirty);
     return m_hasSelfPaintingLayerDescendant;
   }
   LayoutRect paintingExtent(const PaintLayer* rootLayer,
                             const LayoutSize& subPixelAccumulation,
                             GlobalPaintFlags);
   void appendSingleFragmentIgnoringPagination(
       PaintLayerFragments&,
       const PaintLayer* rootLayer,
       const LayoutRect& dirtyRect,
       ClipRectsCacheSlot,
@@ skipping 62 matching lines @@
   LayoutRect previousPaintDirtyRect() const { return m_previousPaintDirtyRect; }
   void setPreviousPaintDirtyRect(const LayoutRect& rect) {
     m_previousPaintDirtyRect = rect;
   }
 
   PaintLayerPainter::PaintResult previousPaintResult() const {
     return static_cast<PaintLayerPainter::PaintResult>(m_previousPaintResult);
   }
   void setPreviousPaintResult(PaintLayerPainter::PaintResult result) {
     m_previousPaintResult = static_cast<unsigned>(result);
-    ASSERT(m_previousPaintResult == static_cast<unsigned>(result));
+    DCHECK(m_previousPaintResult == static_cast<unsigned>(result));
   }
 
   // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never
   // had descendant outlines.  The flag is set during paint invalidation on a
   // self painting layer if any contained object has outline.  It's cleared
   // during painting if PaintPhaseDescendantOutlinesOnly painted nothing.
   // For more details, see core/paint/REAME.md#Empty paint phase optimization.
   bool needsPaintPhaseDescendantOutlines() const {
     return m_needsPaintPhaseDescendantOutlines &&
            !m_previousPaintPhaseDescendantOutlinesWasEmpty;
@@ skipping 199 matching lines @@
   mutable unsigned m_hasSelfPaintingLayerDescendant : 1;
   mutable unsigned m_hasSelfPaintingLayerDescendantDirty : 1;
 
   const unsigned m_isRootLayer : 1;
 
   unsigned m_isVisibleContentDirty : 1;
   unsigned m_hasVisibleContent : 1;
   unsigned m_isVisibleDescendantDirty : 1;
   unsigned m_hasVisibleDescendant : 1;
 
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
   unsigned m_needsPositionUpdate : 1;
 #endif
 
   unsigned m_is3DTransformedDescendantDirty : 1;
   // Set on a stacking context layer that has 3D descendants anywhere
   // in a preserves3D hierarchy. Hint to do 3D-aware hit testing.
   unsigned m_has3DTransformedDescendant : 1;
 
   unsigned m_containsDirtyOverlayScrollbars : 1;
 
@@ skipping 79 matching lines @@
 
 }  // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 CORE_EXPORT void showLayerTree(const blink::PaintLayer*);
 CORE_EXPORT void showLayerTree(const blink::LayoutObject*);
 #endif
 
 #endif  // Layer_h