[Offline Pages] Add evaluation test support in RequestCoordinator.

components/offline_pages/background/request_picker_unittest.cc

Index: components/offline_pages/background/request_picker_unittest.cc
diff --git a/components/offline_pages/background/request_picker_unittest.cc b/components/offline_pages/background/request_picker_unittest.cc
index f71b406460e95dac3365f81cf76a7f8a1cf78243..963f9aa27114a471df4027b6c37d9ab90c38baa2 100644
--- a/components/offline_pages/background/request_picker_unittest.cc
+++ b/components/offline_pages/background/request_picker_unittest.cc
@@ -38,6 +38,7 @@ const int kMaxCompletedTries = 1;
 const bool kPreferUntried = false;
 const bool kPreferEarlier = true;
 const bool kPreferRetryCount = true;
+const int kBackgroundProcessingTimeBudgetSeconds = 170;

[dougarnett, 2016/10/19 00:58:58]

hmm, I wonder about creating instance of OfflinerPolicy and then getting value
from it instead of needing to try to match value here with it.

[romax, 2016/10/19 01:03:21]

Then I guess it's better to go with the idea which would add setter/getter on
OfflinerPolicy because the changes below would utilize those better. WDYT? I can
make another patch on it.

[dougarnett, 2016/10/19 01:36:39]

Sorry, never mind

 
 // Default request
 const SavePageRequest kEmptyRequest(0UL,
@@ -194,9 +195,9 @@ TEST_F(RequestPickerTest, PickFromEmptyQueue) {
 }
 
 TEST_F(RequestPickerTest, ChooseRequestWithHigherRetryCount) {
-  policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
-                                   kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries + 1));
+  policy_.reset(new OfflinerPolicy(
+      kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));
 
@@ -230,9 +231,9 @@ TEST_F(RequestPickerTest, ChooseRequestWithSameRetryCountButEarlier) {
 
 TEST_F(RequestPickerTest, ChooseEarlierRequest) {
   // We need a custom policy object prefering recency to retry count.
-  policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
-                                   !kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries));
+  policy_.reset(new OfflinerPolicy(
+      kPreferUntried, kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));
 
@@ -253,9 +254,9 @@ TEST_F(RequestPickerTest, ChooseEarlierRequest) {
 
 TEST_F(RequestPickerTest, ChooseSameTimeRequestWithHigherRetryCount) {
   // We need a custom policy object preferring recency to retry count.
-  policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
-                                   !kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries + 1));
+  policy_.reset(new OfflinerPolicy(
+      kPreferUntried, kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));
 
@@ -274,9 +275,9 @@ TEST_F(RequestPickerTest, ChooseSameTimeRequestWithHigherRetryCount) {
 
 TEST_F(RequestPickerTest, ChooseRequestWithLowerRetryCount) {
   // We need a custom policy object preferring lower retry count.
-  policy_.reset(new OfflinerPolicy(!kPreferUntried, kPreferEarlier,
-                                   kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries + 1));
+  policy_.reset(new OfflinerPolicy(
+      !kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));
 
@@ -295,9 +296,9 @@ TEST_F(RequestPickerTest, ChooseRequestWithLowerRetryCount) {
 
 TEST_F(RequestPickerTest, ChooseLaterRequest) {
   // We need a custom policy preferring recency over retry, and later requests.
-  policy_.reset(new OfflinerPolicy(kPreferUntried, !kPreferEarlier,
-                                   !kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries));
+  policy_.reset(new OfflinerPolicy(
+      kPreferUntried, !kPreferEarlier, !kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));
 
@@ -377,9 +378,9 @@ TEST_F(RequestPickerTest, ChooseRequestThatHasNotExceededCompletionLimit) {
 
 
 TEST_F(RequestPickerTest, ChooseRequestThatIsNotDisabled) {
-  policy_.reset(new OfflinerPolicy(kPreferUntried, kPreferEarlier,
-                                   kPreferRetryCount, kMaxStartedTries,
-                                   kMaxCompletedTries + 1));
+  policy_.reset(new OfflinerPolicy(
+      kPreferUntried, kPreferEarlier, kPreferRetryCount, kMaxStartedTries,
+      kMaxCompletedTries + 1, kBackgroundProcessingTimeBudgetSeconds));
   picker_.reset(new RequestPicker(queue_.get(), policy_.get(), notifier_.get(),
                                   &event_logger_));