Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2425873002: Add network parameters fields in FrameStatsMessage (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 2 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add network parameters fields in FrameStatsMessage 1. Added rtt_estimate_ms fields for the current network RTT estimate. 2. Added bandwidth_estimate_kbps field for BW estimate used by he host. 3. send_pending_time_ms is set by the host now. The new fields will allow the receiver to estimate total latency without per-frame reports from WebRTC APIs in JS. Committed: https://crrev.com/1e8723caadd302ec806a27f071589b7912b10fe1 Cr-Commit-Position: refs/heads/master@{#426148}

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -15 lines) Patch
M remoting/proto/video_stats.proto View 1 chunk +7 lines, -1 line 0 comments Download
M remoting/protocol/frame_stats.h View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/frame_stats.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_frame_scheduler.h View 2 chunks +6 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_frame_scheduler_simple.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M remoting/protocol/webrtc_frame_scheduler_simple.cc View 1 4 chunks +17 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Sergey Ulanov
4 years, 2 months ago (2016-10-17 23:56:20 UTC) #3
kelvinp
lgtm
4 years, 2 months ago (2016-10-18 23:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425873002/20001
4 years, 2 months ago (2016-10-18 23:48:34 UTC) #8
commit-bot: I haz the power
Failed to apply patch for remoting/protocol/webrtc_frame_scheduler_simple.h: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-19 00:25:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425873002/60001
4 years, 2 months ago (2016-10-19 05:23:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-19 11:09:00 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e8723caadd302ec806a27f071589b7912b10fe1
Cr-Commit-Position: refs/heads/master@{#426148}

Powered by Google App Engine
This is Rietveld 408576698