Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2425863003: Web MIDI Android: Use PROPERTY_NAME if PROPERTY_PRODUCT is empty (Closed)

Created:
4 years, 2 months ago by Takashi Toyoshima
Modified:
4 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI Android: Use PROPERTY_NAME if PROPERTY_PRODUCT is empty On BLE MIDI device, PROPERTY_PRODUCT can be an empty string. To provide better information in MIDIPort interface, use PROPERTY_NAME instead of an empty string. BUG=636455 Committed: https://crrev.com/98132ff7ce96eb3139c4979ba9fe18bab9f49f45 Cr-Commit-Position: refs/heads/master@{#426415}

Patch Set 1 #

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M media/midi/java/src/org/chromium/midi/MidiDeviceAndroid.java View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Takashi Toyoshima
Can you take a look?
4 years, 2 months ago (2016-10-19 05:48:26 UTC) #8
Takashi Toyoshima
revised.
4 years, 2 months ago (2016-10-19 07:06:03 UTC) #10
yhirano
lgtm
4 years, 2 months ago (2016-10-20 04:06:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425863003/20001
4 years, 2 months ago (2016-10-20 04:23:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 05:27:37 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98132ff7ce96eb3139c4979ba9fe18bab9f49f45
Cr-Commit-Position: refs/heads/master@{#426415}

Powered by Google App Engine
This is Rietveld 408576698