chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 2425703003: Fix failing DCHECK in AutoCompleteInput()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2425703003: Fix failing DCHECK in AutoCompleteInput() (Closed)

Patch Set: use pkasting's suggested code Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 6788f3ab8b250b641ce1aaa2f69874c47ffe05b3..98ad3e568cb4cac06b580895a55fe1527c25a65f 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -452,8 +452,7 @@ void OmniboxViewViews::UpdatePopup() {

// Prevent inline autocomplete when the caret isn't at the end of the text.

const gfx::Range sel = GetSelectedRange();

- model()->StartAutocomplete(!sel.is_empty(), sel.GetMax() < text().length(),

- false);

+ model()->StartAutocomplete(!sel.is_empty(), sel.GetMax() < text().length());

}

void OmniboxViewViews::ApplyCaretVisibility() {