Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: components/omnibox/browser/omnibox_edit_model.h

Issue 2425703003: Fix failing DCHECK in AutoCompleteInput() (Closed)
Patch Set: use pkasting's suggested code Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // Invoked any time the text may have changed in the edit. Notifies the 172 // Invoked any time the text may have changed in the edit. Notifies the
173 // controller. 173 // controller.
174 void OnChanged(); 174 void OnChanged();
175 175
176 // Reverts the edit model back to its unedited state (permanent text showing, 176 // Reverts the edit model back to its unedited state (permanent text showing,
177 // no user input in progress). 177 // no user input in progress).
178 void Revert(); 178 void Revert();
179 179
180 // Directs the popup to start autocomplete. 180 // Directs the popup to start autocomplete.
181 void StartAutocomplete(bool has_selected_text, 181 void StartAutocomplete(bool has_selected_text,
182 bool prevent_inline_autocomplete, 182 bool prevent_inline_autocomplete);
183 bool entering_keyword_mode);
184 183
185 // Closes the popup and cancels any pending asynchronous queries. 184 // Closes the popup and cancels any pending asynchronous queries.
186 void StopAutocomplete(); 185 void StopAutocomplete();
187 186
188 // Determines whether the user can "paste and go", given the specified text. 187 // Determines whether the user can "paste and go", given the specified text.
189 bool CanPasteAndGo(const base::string16& text) const; 188 bool CanPasteAndGo(const base::string16& text) const;
190 189
191 // Navigates to the destination last supplied to CanPasteAndGo. 190 // Navigates to the destination last supplied to CanPasteAndGo.
192 void PasteAndGo(const base::string16& text); 191 void PasteAndGo(const base::string16& text);
193 192
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 569
571 // The input that was sent to the AutocompleteController. Since no 570 // The input that was sent to the AutocompleteController. Since no
572 // autocomplete query is started after a tab switch, it is possible for this 571 // autocomplete query is started after a tab switch, it is possible for this
573 // |input_| to differ from the one currently stored in AutocompleteController. 572 // |input_| to differ from the one currently stored in AutocompleteController.
574 AutocompleteInput input_; 573 AutocompleteInput input_;
575 574
576 DISALLOW_COPY_AND_ASSIGN(OmniboxEditModel); 575 DISALLOW_COPY_AND_ASSIGN(OmniboxEditModel);
577 }; 576 };
578 577
579 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_ 578 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_EDIT_MODEL_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698