net/url_request/test_url_fetcher_factory.cc - Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/test_url_fetcher_factory.cc

Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error (Closed)

Patch Set: Fix test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/test_url_fetcher_factory.cc

diff --git a/net/url_request/test_url_fetcher_factory.cc b/net/url_request/test_url_fetcher_factory.cc

index d880fd6ca1801624983f88f14b173b76a17dcbcf..24c9bf1f1b38e822e79aa6240c822c4630947ae3 100644

--- a/net/url_request/test_url_fetcher_factory.cc

+++ b/net/url_request/test_url_fetcher_factory.cc

@@ -188,7 +188,7 @@ void TestURLFetcher::SaveResponseWithWriter(

fake_response_string_.size(),

CompletionCallback());

DCHECK_EQ(static_cast<int>(fake_response_string_.size()), response);

- response = response_writer_->Finish(CompletionCallback());

+ response = response_writer_->Finish(OK, CompletionCallback());

DCHECK_EQ(OK, response);

} else if (fake_response_destination_ == TEMP_FILE) {

// SaveResponseToFileAtPath() should be called instead of this method to

« no previous file with comments | « google_apis/drive/base_requests.cc ('k') | net/url_request/url_fetcher_core.cc » ('j') | no next file with comments »