Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2425623002: Get rid of flat tree version of createVisibleSelection() taking two VisiblePositionInFlatTree (Closed)
Patch Set: 2016-10-20T13:19:29 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index b50525cf79dc8572f7547fd19ce850004a298dfe..3b1fc13c4d60a925a42a99e43bb80b18aa48b937 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -150,18 +150,6 @@ VisibleSelectionInFlatTree createVisibleSelection(
return createVisibleSelection(builder.build());
}
-VisibleSelectionInFlatTree createVisibleSelection(
- const VisiblePositionInFlatTree& base,
- const VisiblePositionInFlatTree& extent,
- bool isDirectional) {
- DCHECK(base.isValid());
- DCHECK(extent.isValid());
- // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
- // after all call sites have ensured that.
- return createVisibleSelection(base.deepEquivalent(), extent.deepEquivalent(),
- base.affinity(), isDirectional);
-}
-
template <typename Strategy>
static SelectionType computeSelectionType(
const PositionTemplate<Strategy>& start,
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698