components/bookmarks: convert usage of FOR_EACH_OBSERVER macro

components/bookmarks: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

This patch was generated by the following command line:
$ cd components/bookmarks
$ perl -0777 -pi -e
's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for
(\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq)

And then manually inspected for line indentation fixes.

BUG=655021
TEST=components_unittests
R=sky@chromium.org

Committed: https://crrev.com/2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc
Cr-Commit-Position: refs/heads/master@{#426113}

[tfarina, 2016-10-18 19:22:51]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 19:23:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 19:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 19:28:01]

Dry run: Exceeded global retry quota

[tfarina, 2016-10-18 20:27:51]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 20:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:37:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2016-10-18 20:45:08]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:45:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:33:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-18 21:38:41]

https://codereview.chromium.org/2425603005/diff/40001/components/bookmarks/br...
File components/bookmarks/browser/bookmark_model.cc (left):

https://codereview.chromium.org/2425603005/diff/40001/components/bookmarks/br...
components/bookmarks/browser/bookmark_model.cc:440:
FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
Why did you remove this one?

[tfarina, 2016-10-18 21:48:55]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-10-18 21:49:35]

https://codereview.chromium.org/2425603005/diff/40001/components/bookmarks/br...
File components/bookmarks/browser/bookmark_model.cc (left):

https://codereview.chromium.org/2425603005/diff/40001/components/bookmarks/br...
components/bookmarks/browser/bookmark_model.cc:440:
FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
On 2016/10/18 21:38:41, sky wrote:
> Why did you remove this one?

Sorry, something went wrong when I was editing this on emacs. Added it back.

[commit-bot: I haz the power, 2016-10-18 22:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:34:27]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2016-10-18 22:57:39]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 22:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-10-18 23:54:38]

LGTM

[Eric Willigers, 2016-10-19 00:05:14]

The CQ bit was unchecked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-19 00:05:20]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:30:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:30:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2016-10-19 01:20:35]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-10-19 01:33:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 01:45:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:05:38]

Description was changed from

==========
components/bookmarks: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

This patch was generated by the following command line:
$ cd components/bookmarks
$ perl -0777 -pi -e
's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for
(\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 |
uniq)

And then manually inspected for line indentation fixes.

BUG=655021
TEST=components_unittests
R=sky@chromium.org
==========

to

==========
components/bookmarks: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

This patch was generated by the following command line:
$ cd components/bookmarks
$ perl -0777 -pi -e
's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for
(\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 |
uniq)

And then manually inspected for line indentation fixes.

BUG=655021
TEST=components_unittests
R=sky@chromium.org

Committed: https://crrev.com/2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc
Cr-Commit-Position: refs/heads/master@{#426113}
==========

[commit-bot: I haz the power, 2016-10-21 13:05:39]

Patchset 5 (id:??) landed as
https://crrev.com/2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc
Cr-Commit-Position: refs/heads/master@{#426113}