Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: components/bubble/bubble_manager.cc

Issue 2425603004: Remove usage of FOR_EACH_OBSERVER macro in components/translate (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/translate/content/browser/content_translate_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_manager.cc
diff --git a/components/bubble/bubble_manager.cc b/components/bubble/bubble_manager.cc
index dc94dc25fb76ab99ef7989b32248c7e8eb6f4221..acb9e7f3b35a5536c5aec62029d1aa647bcbc7cb 100644
--- a/components/bubble/bubble_manager.cc
+++ b/components/bubble/bubble_manager.cc
@@ -33,8 +33,8 @@ BubbleReference BubbleManager::ShowBubble(
controllers_.push_back(std::move(controller));
break;
case NO_MORE_BUBBLES:
- FOR_EACH_OBSERVER(BubbleManagerObserver, observers_,
- OnBubbleNeverShown(controller->AsWeakPtr()));
+ for (auto& observer : observers_)
+ observer.OnBubbleNeverShown(controller->AsWeakPtr());
break;
default:
NOTREACHED();
@@ -125,8 +125,8 @@ bool BubbleManager::CloseAllMatchingBubbles(
for (auto* controller : close_queue) {
controller->DoClose(reason);
- FOR_EACH_OBSERVER(BubbleManagerObserver, observers_,
- OnBubbleClosed(controller->AsWeakPtr(), reason));
+ for (auto& observer : observers_)
+ observer.OnBubbleClosed(controller->AsWeakPtr(), reason);
}
return !close_queue.empty();
« no previous file with comments | « no previous file | components/translate/content/browser/content_translate_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698