Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2425603004: Remove usage of FOR_EACH_OBSERVER macro in components/translate (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, msw+watch_chromium.org, jam, groby+bubble_chromium.org, darin-cc_chromium.org, hcarmona+bubble_chromium.org, rouslan+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in components/translate Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/da4988bb37c6d17714361ce75d532debbfd8ea17 Cr-Commit-Position: refs/heads/master@{#426697}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M components/bubble/bubble_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eric Willigers
4 years, 2 months ago (2016-10-18 09:00:48 UTC) #2
groby-ooo-7-16
lgtm
4 years, 2 months ago (2016-10-21 00:43:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425603004/20001
4 years, 2 months ago (2016-10-21 00:45:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 02:27:13 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:26:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da4988bb37c6d17714361ce75d532debbfd8ea17
Cr-Commit-Position: refs/heads/master@{#426697}

Powered by Google App Engine
This is Rietveld 408576698