Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2425563003:
Bail out in AstTraversalVisitor::VisitFunctionBody for lazy functions (Closed)
|
Created:
4 years, 2 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 1 month ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionBail out in AstTraversalVisitor::VisitFunctionBody for lazy functions
R=verwaest@chromium.org,mstarzinger@chromium.org
BUG=
Committed: https://crrev.com/eafa9206acbb95e491a49dabc67d61eed7af2268
Cr-Commit-Position: refs/heads/master@{#40442}
Patch Set 1 #
Total comments: 2
Patch Set 2 : updates #Patch Set 3 : updates #Messages
Total messages: 22 (13 generated)
LGTM.
https://codereview.chromium.org/2425563003/diff/1/src/ast/ast-traversal-visit... File src/ast/ast-traversal-visitor.h (right): https://codereview.chromium.org/2425563003/diff/1/src/ast/ast-traversal-visit... src/ast/ast-traversal-visitor.h:291: // A lazily parsed function literal won't have a body. Why not just check expr->is_lazily_parsed()?
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2425563003/diff/1/src/ast/ast-traversal-visit... File src/ast/ast-traversal-visitor.h (right): https://codereview.chromium.org/2425563003/diff/1/src/ast/ast-traversal-visit... src/ast/ast-traversal-visitor.h:291: // A lazily parsed function literal won't have a body. On 2016/10/18 at 08:21:42, Toon Verwaest wrote: > Why not just check expr->is_lazily_parsed()? done
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2425563003/#ps40001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jochen@chromium.org
lgtm
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Bail out in AstTraversalVisitor::VisitFunctionBody for lazy functions R=verwaest@chromium.org,mstarzinger@chromium.org BUG= ========== to ========== Bail out in AstTraversalVisitor::VisitFunctionBody for lazy functions R=verwaest@chromium.org,mstarzinger@chromium.org BUG= Committed: https://crrev.com/eafa9206acbb95e491a49dabc67d61eed7af2268 Cr-Commit-Position: refs/heads/master@{#40442} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/eafa9206acbb95e491a49dabc67d61eed7af2268 Cr-Commit-Position: refs/heads/master@{#40442} |
