Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: chrome/test/data/webui/settings/search_engines_page_test.js

Issue 2425423005: MD Settings: Close action menu when search engine is removed. (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('settings_search_engines_page', function() { 5 cr.define('settings_search_engines_page', function() {
6 /** 6 /**
7 * @param {boolean} canBeDefault 7 * @param {boolean} canBeDefault
8 * @param {boolean} canBeEdited 8 * @param {boolean} canBeEdited
9 * @param {boolean} canBeRemoved 9 * @param {boolean} canBeRemoved
10 * @return {!SearchEngine} 10 * @return {!SearchEngine}
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 var keywordElement = entry.$$('.keyword-column'); 169 var keywordElement = entry.$$('.keyword-column');
170 assertTrue(!!keywordElement); 170 assertTrue(!!keywordElement);
171 assertEquals(searchEngine.keyword, keywordElement.textContent); 171 assertEquals(searchEngine.keyword, keywordElement.textContent);
172 172
173 var urlElement = entry.$$('.url-column'); 173 var urlElement = entry.$$('.url-column');
174 assertTrue(!!urlElement); 174 assertTrue(!!urlElement);
175 assertEquals(searchEngine.url, urlElement.textContent); 175 assertEquals(searchEngine.url, urlElement.textContent);
176 }); 176 });
177 177
178 test('Remove_Enabled', function() { 178 test('Remove_Enabled', function() {
179 // Open action menu.
180 MockInteractions.tap(entry.$$('paper-icon-button'));
181 var menu = entry.$$('dialog[is=settings-action-menu]');
182 assertTrue(menu.open);
183
179 var deleteButton = entry.$.delete; 184 var deleteButton = entry.$.delete;
180 assertTrue(!!deleteButton); 185 assertTrue(!!deleteButton);
181 assertFalse(deleteButton.hidden); 186 assertFalse(deleteButton.hidden);
182 MockInteractions.tap(deleteButton); 187 MockInteractions.tap(deleteButton);
183 return browserProxy.whenCalled('removeSearchEngine').then( 188 return browserProxy.whenCalled('removeSearchEngine').then(
184 function(modelIndex) { 189 function(modelIndex) {
190 assertFalse(menu.open);
185 assertEquals(entry.engine.modelIndex, modelIndex); 191 assertEquals(entry.engine.modelIndex, modelIndex);
186 }); 192 });
187 }); 193 });
188 194
189 test('MakeDefault_Enabled', function() { 195 test('MakeDefault_Enabled', function() {
190 // Open action menu. 196 // Open action menu.
191 MockInteractions.tap(entry.$$('paper-icon-button')); 197 MockInteractions.tap(entry.$$('paper-icon-button'));
198 var menu = entry.$$('dialog[is=settings-action-menu]');
199 assertTrue(menu.open);
192 200
193 var makeDefaultButton = entry.$.makeDefault; 201 var makeDefaultButton = entry.$.makeDefault;
194 assertTrue(!!makeDefaultButton); 202 assertTrue(!!makeDefaultButton);
195 MockInteractions.tap(makeDefaultButton); 203 MockInteractions.tap(makeDefaultButton);
196 return browserProxy.whenCalled('setDefaultSearchEngine').then( 204 return browserProxy.whenCalled('setDefaultSearchEngine').then(
197 function(modelIndex) { 205 function(modelIndex) {
206 assertFalse(menu.open);
198 assertEquals(entry.engine.modelIndex, modelIndex); 207 assertEquals(entry.engine.modelIndex, modelIndex);
199 }); 208 });
200 }); 209 });
201 210
202 // Test that clicking the "edit" button brings up a dialog. 211 // Test that clicking the "edit" button brings up a dialog.
203 test('Edit_Enabled', function() { 212 test('Edit_Enabled', function() {
204 // Open action menu. 213 // Open action menu.
205 MockInteractions.tap(entry.$$('paper-icon-button')); 214 MockInteractions.tap(entry.$$('paper-icon-button'));
215 var menu = entry.$$('dialog[is=settings-action-menu]');
216 assertTrue(menu.open);
206 217
207 var engine = entry.engine; 218 var engine = entry.engine;
208 var editButton = entry.$.edit; 219 var editButton = entry.$.edit;
209 assertTrue(!!editButton); 220 assertTrue(!!editButton);
210 assertFalse(editButton.hidden); 221 assertFalse(editButton.hidden);
211 MockInteractions.tap(editButton); 222 MockInteractions.tap(editButton);
212 return browserProxy.whenCalled('searchEngineEditStarted').then( 223 return browserProxy.whenCalled('searchEngineEditStarted').then(
213 function(modelIndex) { 224 function(modelIndex) {
214 assertEquals(engine.modelIndex, modelIndex); 225 assertEquals(engine.modelIndex, modelIndex);
215 var dialog = entry.$$('settings-search-engine-dialog'); 226 var dialog = entry.$$('settings-search-engine-dialog');
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 378
368 return { 379 return {
369 registerTests: function() { 380 registerTests: function() {
370 registerDialogTests(); 381 registerDialogTests();
371 registerSearchEngineEntryTests(); 382 registerSearchEngineEntryTests();
372 registerOmniboxExtensionEntryTests(); 383 registerOmniboxExtensionEntryTests();
373 registerPageTests(); 384 registerPageTests();
374 }, 385 },
375 }; 386 };
376 }); 387 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698