Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 24253005: Add a gyp variable to indicate additional native libraries to be included in the APK (Closed)

Created:
7 years, 3 months ago by Peter Beverloo
Modified:
7 years, 3 months ago
Reviewers:
cjhopman, bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Add a gyp variable to indicate additional native libraries to be included in the APK Based on a patch by Chris Hopman <cjhopman@chromium.org>;. This patch allows us to lazily load libosmesa.so only when it's needed for content_shell, rather than directly linking it. https://codereview.chromium.org/23868030/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/java_apk.gypi View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
+Chris for review, bulach for second-eyes.
7 years, 3 months ago (2013-09-19 14:30:24 UTC) #1
bulach
lgtm, thanks for the extra info!
7 years, 3 months ago (2013-09-19 17:31:34 UTC) #2
cjhopman
lgtm
7 years, 3 months ago (2013-09-19 18:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/24253005/1
7 years, 3 months ago (2013-09-20 12:24:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200036
7 years, 3 months ago (2013-09-20 16:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/24253005/1
7 years, 3 months ago (2013-09-20 16:31:04 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 17:44:45 UTC) #7
Message was sent while issue was closed.
Change committed as 224424

Powered by Google App Engine
This is Rietveld 408576698