Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2425293003: [Android, Media, Test] Fix VideoTest.java on low-end devices (Closed)

Created:
4 years, 2 months ago by whywhat
Modified:
4 years, 2 months ago
Reviewers:
Ted C, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android, Media, Test] Fix VideoTest.java on low-end devices Call load() on the media element to overcome the forced preload=none on low-end devices. BUG=654411 TEST=run the test locally on a low-end device Committed: https://crrev.com/56ed0f1a962c25e882be130015ba53e7ab14993b Cr-Commit-Position: refs/heads/master@{#426195}

Patch Set 1 #

Patch Set 2 : Accidental blank line removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/android/media/video-play.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
whywhat
PTaL
4 years, 2 months ago (2016-10-19 02:46:56 UTC) #2
whywhat
Accidental blank line removed
4 years, 2 months ago (2016-10-19 02:47:39 UTC) #3
Ted C
lgtm
4 years, 2 months ago (2016-10-19 04:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425293003/20001
4 years, 2 months ago (2016-10-19 15:01:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 15:13:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56ed0f1a962c25e882be130015ba53e7ab14993b
Cr-Commit-Position: refs/heads/master@{#426195}

Powered by Google App Engine
This is Rietveld 408576698