Issue 242513005: Remove some test files from extensions_unittests target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242513005: Remove some test files from extensions_unittests target. (Closed)

Created:
6 years, 8 months ago by tfarina

Modified:
6 years, 8 months ago

Reviewers:
James Cook, Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove some test files from extensions_unittests target. These are the test files that contains tests that are not passing. For now we decided to remove them from extensions_unittests and add them back with them fixed in a case-by-case approach. So we should not land patches with tests that break extensions_unittests in future. We will require that new tests added to it will have be fully passing. BUG=348066 TEST=extensions_unittests passes R=jamescook@chromium.org, yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264948

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	extensions/extensions.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/242513005/1

6 years, 8 months ago (2014-04-19 18:25:36 UTC) #5

tfarina

6 years, 8 months ago (2014-04-20 22:12:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r264948 (presubmit successful).

Expand Messages | Collapse Messages