third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp - Issue 2425113002: Fix the linear-rgb canvas color space so that it renders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 2425113002: Fix the linear-rgb canvas color space so that it renders (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp ('K') | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h ('k') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

index 27d115b6f7ae213503d48f3faa92727c7bd0a47e..689feb0b32fa49119a5579488bce784ca0158dc6 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

@@ -21,8 +21,9 @@ RecordingImageBufferSurface::RecordingImageBufferSurface(

const IntSize& size,

std::unique_ptr<RecordingImageBufferFallbackSurfaceFactory> fallbackFactory,

OpacityMode opacityMode,

- sk_sp<SkColorSpace> colorSpace)

- : ImageBufferSurface(size, opacityMode, std::move(colorSpace)),

+ sk_sp<SkColorSpace> colorSpace,

+ SkColorType colorType)

+ : ImageBufferSurface(size, opacityMode, std::move(colorSpace), colorType),

m_imageBuffer(0),

m_currentFramePixelCount(0),

m_previousFramePixelCount(0),

@@ -94,8 +95,8 @@ void RecordingImageBufferSurface::fallBackToRasterCanvas(

FallbackReasonCount));

canvasFallbackHistogram.count(reason);

- m_fallbackSurface =

- m_fallbackFactory->createSurface(size(), getOpacityMode(), colorSpace());

+ m_fallbackSurface = m_fallbackFactory->createSurface(

+ size(), getOpacityMode(), colorSpace(), colorType());

m_fallbackSurface->setImageBuffer(m_imageBuffer);

if (m_previousFrame) {