Fix the linear-rgb canvas color space so that it renders

third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 14 matching lines @@
 
 #ifndef CanvasRenderingContext_h
 #define CanvasRenderingContext_h
 
 #include "core/CoreExport.h"
 #include "core/html/HTMLCanvasElement.h"
 #include "core/html/canvas/CanvasContextCreationAttributes.h"
 #include "core/layout/HitTestCanvasResult.h"
 #include "core/offscreencanvas/OffscreenCanvas.h"
 #include "third_party/skia/include/core/SkColorSpace.h"
+#include "third_party/skia/include/core/SkImageInfo.h"
 #include "wtf/HashSet.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/text/StringHash.h"
 
 class SkCanvas;
 
 namespace blink {
 
 class CanvasImageSource;
 class HTMLCanvasElement;
@@ skipping 33 matching lines @@
   };
 
   static ContextType contextTypeFromId(const String& id);
   static ContextType resolveContextTypeAliases(ContextType);
 
   HTMLCanvasElement* canvas() const { return m_canvas; }
 
   CanvasColorSpace colorSpace() const { return m_colorSpace; };
   WTF::String colorSpaceAsString() const;
   sk_sp<SkColorSpace> skColorSpace() const;
+  SkColorType colorType() const;

[xidachen, 2016/10/18 15:40:37]

Should we make it more consistent? As we call skColorSpace(), maybe we should
call this one skColorType(), WDYT?

[Justin Novosad, 2016/10/18 17:02:41]

In general we should not use sk prefixes in blink.
The only reason the method is called skColorSpace in CanvasRenderingContext is
to avoid a name conflict. Basically, that class has two representations: the
ColorSpace enum (which maps to the IDL dictionary) and the SkColorSpace. C++
does not allow overloads that differ only by return type.

 
   virtual PassRefPtr<Image> getImage(AccelerationHint,
                                      SnapshotReason) const = 0;
   virtual ContextType getContextType() const = 0;
   virtual bool isAccelerated() const { return false; }
   virtual bool shouldAntialias() const { return false; }
   virtual void setIsHidden(bool) = 0;
   virtual bool isContextLost() const { return true; }
   virtual void setCanvasGetContextResult(RenderingContext&) { NOTREACHED(); };
   virtual void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) {
@@ skipping 89 matching lines @@
   Member<OffscreenCanvas> m_offscreenCanvas;
   HashSet<String> m_cleanURLs;
   HashSet<String> m_dirtyURLs;
   CanvasColorSpace m_colorSpace;
   CanvasContextCreationAttributes m_creationAttributes;
 };
 
 }  // namespace blink
 
 #endif