Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 24251005: SimpleCache: fix error in computation of crc32 for stream 0 (Closed)

Created:
7 years, 3 months ago by clamy
Modified:
7 years, 3 months ago
Reviewers:
pasko, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

SimpleCache: fix error in computation of crc32 for stream 0 This CL fixes the following problem: 1) An EOF record for stream 0 is written to disk with no crc32. 2) The entry is opened, and the wrong crc32 (from the EOF records, that is invalid) is assigned as the computed value for stream 0. 3) Something is written to stream1 but not to stream 0 and the entry is closed. An EOF record needs to be written for stream 0, where the HAS_CRC32 flag is on, but which has the wrong value. 4) Next open will fail because of wrong value of crc32 for stream 0. BUG=173398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/disk_cache/simple/simple_synchronous_entry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
clamy
pasko, gavinp: PTAL Found this while working on the testing CL. I guess I should ...
7 years, 3 months ago (2013-09-19 13:00:33 UTC) #1
pasko
lgtm LGTM great catch! since this depends on stream0 not being written in sequence, I ...
7 years, 3 months ago (2013-09-19 13:06:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/24251005/1
7 years, 3 months ago (2013-09-19 13:06:46 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 15:44:48 UTC) #4
Message was sent while issue was closed.
Change committed as 224138

Powered by Google App Engine
This is Rietveld 408576698