Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2425093002:
[profiler] Update cpu profile tracing format. (Closed)
Description[profiler] Update cpu profile tracing format.
Encapsulate nodes and samples into cpuProfile object.
BUG=chromium:406277
Committed: https://crrev.com/fa0f953297518966a6989de79283a665fcff2c7e
Cr-Commit-Position: refs/heads/master@{#40480}
Patch Set 1 #Patch Set 2 : CpuProfile -> Profile #
Messages
Total messages: 25 (10 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org, lpy@chromium.org
ptal
Thank you! I think we shouldn't call it `CpuProfile` and `CpuProfileChunk` as trace event names, we should use a generic name, maybe just `Sample`, or maybe just `Profile`? WDYT? LGTM!
Good point. Updated.
alph@chromium.org changed reviewers: + yangguo@chromium.org
Yang, could you please take a look.
On 2016/10/18 18:42:26, alph wrote: > Yang, could you please take a look. lgtm
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lpy@chromium.org Link to the patchset: https://codereview.chromium.org/2425093002/#ps20001 (title: "CpuProfile -> Profile")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://chromiumcodereview.appspot.com/2432373004/ by machenbach@chromium.org. The reason for reverting is: Breaks https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui... See also: https://github.com/v8/v8/wiki/Blink-layout-tests.
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
Looks like the test stopped failing a few builds later but was overlapped by another breakage. Can be that it interacted with this rebaseline that just happened: https://codereview.chromium.org/2433993003 Please make sure that the two CLs needing rebaseline didn't lead to an undesired interaction, causing a wrong new baseline. If it's ok, then please reland, but make sure that no new baseline is required.
Message was sent while issue was closed.
Description was changed from ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 ========== to ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 ==========
On 2016/10/20 08:47:31, machenbach (slow) wrote: > Looks like the test stopped failing a few builds later but was overlapped by > another breakage. Can be that it interacted with this rebaseline that just > happened: > > https://codereview.chromium.org/2433993003 > > Please make sure that the two CLs needing rebaseline didn't lead to an undesired > interaction, causing a wrong new baseline. If it's ok, then please reland, but > make sure that no new baseline is required. The CL is a profiler change. It has no relation to debugger and its tests. The failure is likely caused by the auto-rebaseline mentioned above, which is also unrelated to the CL, and triggered by another CL. I'll try to reland.
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 ========== to ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
hmja - stayed green this time... strange...
Message was sent while issue was closed.
Description was changed from ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 ========== to ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 Committed: https://crrev.com/71e390faf6ba0bf318ebb6e5c43dc7891c2eb3e7 Cr-Commit-Position: refs/heads/master@{#40447} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/71e390faf6ba0bf318ebb6e5c43dc7891c2eb3e7 Cr-Commit-Position: refs/heads/master@{#40447}
Message was sent while issue was closed.
Description was changed from ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 Committed: https://crrev.com/71e390faf6ba0bf318ebb6e5c43dc7891c2eb3e7 Cr-Commit-Position: refs/heads/master@{#40447} ========== to ========== [profiler] Update cpu profile tracing format. Encapsulate nodes and samples into cpuProfile object. BUG=chromium:406277 Committed: https://crrev.com/fa0f953297518966a6989de79283a665fcff2c7e Cr-Commit-Position: refs/heads/master@{#40480} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fa0f953297518966a6989de79283a665fcff2c7e Cr-Commit-Position: refs/heads/master@{#40480} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
