Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2424983002: Harmonize the style of obsolete protos to match that of chrome_device_settings.proto. (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
Reviewers:
peletskyi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmonize the style of obsolete protos to match that of chrome_device_settings.proto. Preparation for sync with server. BUG=645078 Committed: https://crrev.com/c89efcfde96aafbc938d2ac4309d466a0f0fb31c Cr-Commit-Position: refs/heads/master@{#426434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/policy/proto/device_management_backend.proto View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Thiemo Nagel
Hi Sasha, could you please take a look? Thank you, Thiemo
4 years, 2 months ago (2016-10-17 18:55:50 UTC) #3
peletskyi
On 2016/10/17 18:55:50, Thiemo Nagel (slow) wrote: > Hi Sasha, > > could you please ...
4 years, 2 months ago (2016-10-19 08:06:11 UTC) #8
Thiemo Nagel
> LGTM Thank you!
4 years, 2 months ago (2016-10-20 08:27:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424983002/1
4 years, 2 months ago (2016-10-20 08:27:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 09:16:34 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c89efcfde96aafbc938d2ac4309d466a0f0fb31c
Cr-Commit-Position: refs/heads/master@{#426434}

Powered by Google App Engine
This is Rietveld 408576698