Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2424933002: Re-enable CHECK() than only 0-numbered objects are released (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-enable CHECK() than only 0-numbered objects are released. Committed: https://pdfium.googlesource.com/pdfium/+/5532835aeb884642571be2f7b741b5f49f76cd64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M core/fpdfapi/parser/cpdf_object.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Tom Sepez
Lei, for review. The fix that should allow this to succeed is 381fc833ac9, which occurred ...
4 years, 2 months ago (2016-10-17 16:48:30 UTC) #5
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-17 22:44:55 UTC) #8
Tom Sepez
Time to try this one again? I think so.
4 years, 2 months ago (2016-10-21 19:58:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424933002/1
4 years, 2 months ago (2016-10-21 20:06:35 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:53:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5532835aeb884642571be2f7b741b5f49f76...

Powered by Google App Engine
This is Rietveld 408576698